Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update confusing GitVersionVerbosity docs #2590

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@GeertvanHorrik
Copy link
Contributor

commented Aug 5, 2019

Since the docs said: "only log info", I assumed this was a flagged enum, but according to the source, it's not:

https://github.com/cake-build/cake/blob/main/src/Cake.Common/Tools/GitVersion/GitVersionRunner.cs

Since the docs said: "only log info", I assumed this was a flagged enum, but according to the source, it's not:

https://github.com/cake-build/cake/blob/main/src/Cake.Common/Tools/GitVersion/GitVersionRunner.cs
@gep13
gep13 approved these changes Aug 5, 2019
Copy link
Member

left a comment

LGTM!

@gep13 gep13 added the Documentation label Aug 5, 2019
@gep13 gep13 added this to the v0.35.0 milestone Aug 5, 2019
@gep13 gep13 merged commit 71f85ed into cake-build:main Aug 5, 2019
4 checks passed
4 checks passed
ci/bitrise/42eaef77e8db4a5c/pr Passed - macOS Cake
Details
ci/bitrise/ea0c6b3c61eb1e79/pr Passed - Ubuntu Cake
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
@gep13

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

@GeertvanHorrik your changes have been merged, thanks for your contribution 👍

@gep13

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

@GeertvanHorrik It has just been pointed out to me by @devlead that I really shouldn't have merged this, as it is targeting the main branch, rather than the develop branch. Is there a reason that you chose to target the non-default branch? I am going to correct this just now, so that everything is in line when we come to do our next release.

@gep13

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

@GeertvanHorrik I have moved this commit to here on the develop branch: 8174dc0

gep13 added a commit that referenced this pull request Aug 5, 2019
This reverts commit 71f85ed, reversing
changes made to 24fa8d9.
@gep13

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

@GeertvanHorrik and I have backed out the change on the main branch here: 3e98161

@gep13

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

@GeertvanHorrik apologies for this, I should have noticed this on the original PR.

@GeertvanHorrik

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

Sorry, I just merged to the default branch, will take better care next time.

@gep13

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

@GeertvanHorrik said..
Sorry, I just merged to the default branch, will take better care next time.

This is the part that I don't understand though. The develop branch is the default branch for this repository.

@gep13

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

@GeertvanHorrik also, no need to apologise, this was totally my fault!

@GeertvanHorrik

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

@GeertvanHorrik said..
Sorry, I just merged to the default branch, will take better care next time.

This is the part that I don't understand though. The develop branch is the default branch for this repository.

Maybe I was browsing the master branch via GitHub. I just clicked "edit file" and edited in GH itself.

@gep13

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

@GeertvanHorrik said...
Maybe I was browsing the master branch via GitHub. I just clicked "edit file" and edited in GH itself.

Ah, that might explain it! 😄 Like I say, no harm done, I should have verified this before merging the PR, but I missed it. All sorted now though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.