Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible null dereference and remove excessive operator '?.' #2633

wants to merge 2 commits into
base: develop


Copy link

commented Oct 5, 2019

Here are small improvements

possible NRE

var filename = PathHelper.GetFileName(this);
var index = filename.LastIndexOf('.');

and remove the operator '?.' when expression is always not null

Assert.Equal("Fail", result?.Message);

Please review
Thank you in advance

Marusyk added 2 commits Oct 5, 2019

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

can anybody fix the build?


This comment has been minimized.

Copy link

commented Oct 8, 2019

@Marusyk Triggered a rebuild for you. Ping again if it fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.