Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH2673: Add additional properties for .NET Core 3 publishing features #2674

Merged

Conversation

@flcdrg
Copy link
Contributor

flcdrg commented Nov 29, 2019

  • PublishSingleFile
  • PublishTrimmed
  • TieredCompilationQuickJit
  • TieredCompilation
  • PublishReadyToRun

Implements #2673

@gep13 gep13 changed the title [GH2673] Add additional properties for .NET Core 3 publishing features GH2673: Add additional properties for .NET Core 3 publishing features Nov 29, 2019
@patriksvensson

This comment has been minimized.

Copy link
Member

patriksvensson commented Nov 29, 2019

@flcdrg Looks good to me! Since this PR involves more changes than the original issue, would you mind updating the issue to reflect this? That way we will get a correct change log once we release the next version.

@flcdrg

This comment has been minimized.

Copy link
Contributor Author

flcdrg commented Nov 29, 2019

Updated issue as requested

- PublishSingleFile
- PublishTrimmed
- TieredCompilationQuickJit
- TieredCompilation
- PublishReadyToRun

Implements #2673
@devlead devlead force-pushed the flcdrg:DotNetCore3DotNetCorePublishSettings branch from 7d68e43 to b7ae262 Dec 3, 2019
@devlead
devlead approved these changes Dec 3, 2019
Copy link
Member

devlead left a comment

LGMT 👍

@devlead devlead merged commit b7ae262 into cake-build:develop Dec 3, 2019
13 of 14 checks passed
13 of 14 checks passed
Build (windows-latest)
Details
Build (ubuntu-latest)
Details
Build (macos-latest)
Details
Cake Develop (Cake) TeamCity build failed
Details
Azure Pipelines - Build Cake Centos 7 #8498 succeeded
Details
Azure Pipelines - Build Cake Debian Stretch #8500 succeeded
Details
Azure Pipelines - Build Cake Fedora 28 #8499 succeeded
Details
Azure Pipelines - Build Cake Mac #0.36.0-PullRequest2674.49 succeeded
Details
Azure Pipelines - Build Cake Ubuntu #0.36.0-PullRequest2674.49 succeeded
Details
Azure Pipelines - Build Cake Windows #0.36.0-DotNetCore3DotNetCorePublishSettings.1+49 succeeded
Details
ci/bitrise/42eaef77e8db4a5c/pr Passed - macOS Cake
Details
ci/bitrise/ea0c6b3c61eb1e79/pr Passed - Ubuntu Cake
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
@devlead

This comment has been minimized.

Copy link
Member

devlead commented Dec 3, 2019

@flcdrg your changes have been merged, thanks for your contribution 👍

@flcdrg flcdrg deleted the flcdrg:DotNetCore3DotNetCorePublishSettings branch Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.