Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed change: Add Cake.SynVer, remove Cake.SemVer.FromAssembly #307

Merged
merged 2 commits into from
Mar 18, 2017
Merged

Proposed change: Add Cake.SynVer, remove Cake.SemVer.FromAssembly #307

merged 2 commits into from
Mar 18, 2017

Conversation

wallymathieu
Copy link
Contributor

Cake.SemVer.FromAssembly is now obsolete. The role has been taken over by Cake.SynVer.

@dnfclas
Copy link

dnfclas commented Mar 18, 2017

@wallymathieu,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

@dnfclas
Copy link

dnfclas commented Mar 18, 2017

@wallymathieu, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 4b74de6 into cake-build:develop Mar 18, 2017
@gep13
Copy link
Member

gep13 commented Mar 18, 2017

@wallymathieu thank you for keeping us up to date with this.

To avoid the duplication of the NuGet packages, can I suggest that you follow the deprecation process outlined here:

https://chocolatey.org/docs/how-to-deprecate-a-chocolatey-package

Yes, that is the process followed for Chocolatey Packages, but the same process applies equally to NuGet Packages.

cake-build-bot pushed a commit that referenced this pull request Mar 18, 2017
Merge pull request #307 from wallymathieu/patch-1

Proposed change: Add Cake.SynVer, remove Cake.SemVer.FromAssembly
@wallymathieu wallymathieu deleted the patch-1 branch March 19, 2017 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants