Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with replacing Cake.Recipe for integration tests #306

Closed
gep13 opened this issue Dec 16, 2018 · 3 comments
Closed

Fix issue with replacing Cake.Recipe for integration tests #306

gep13 opened this issue Dec 16, 2018 · 3 comments
Assignees
@gep13
Labels
Bug
Milestone
1.0.0

Comments

@gep13
Copy link
Member

gep13 commented Dec 16, 2018

Integration Tests extract latest content into the Cake.Recipe folder, but in-proc NuGet Client restores into a versioned number folder:

image

Not immediately clear on what can be done to resolve this.

@mholo65 did you have any ideas here? Is there a way to tell the in-proc NuGet client to NOT do anything?
@gep13 gep13 added the Bug label Dec 16, 2018
@gep13 gep13 added this to the 0.3.0 milestone Dec 16, 2018
@gep13 gep13 self-assigned this Dec 16, 2018
@bjorkstromm
Copy link
Member

@gep13, no there’s no way to do that, as this is a functionality of NuGet itself.

What you want to do is to install Cake.Recipe from local source in integration tests. Take a look at Bakery integration tests, we do that there as well.

@gep13
Copy link
Member Author

gep13 commented Dec 17, 2018

For reference...

https://github.com/cake-build/bakery/blob/develop/setup.cake#L214

gep13 added a commit to gep13/Cake.Recipe that referenced this issue Apr 22, 2019
@gep13
(cake-contribGH-306) Put message in here
0f77aaf 
blah blah
gep13 added a commit to gep13/Cake.Recipe that referenced this issue Apr 23, 2019
@gep13
(cake-contribGH-306) Rebase me...
310afc8
@gep13
Copy link
Member Author

gep13 commented Apr 23, 2019

This has been fixed, as discussed on live stream on the topic.

The integration tests now update the setup/recipe .cake file for the test repository, to restore Cake.Recipe from a file:// location, rather than from NuGet. That means, the version of Cake.Recipe that was just built is what is used for testing.

@gep13 gep13 closed this as completed Apr 23, 2019
gep13 added a commit that referenced this issue Apr 23, 2019
@gep13
(GH-306) Fix integration tests
dbb2a68 
Rather than attempting to unzip the newly built Cake.Recipe NuPkg
directly to the tools folder in the cloned repositories, resolve the
NuPkg by altering the load preprocessor directive in each cloned
repository.  This can be done using a simple Regular Express search
and replace.
gep13 added a commit that referenced this issue Apr 23, 2019
@gep13
(GH-306) Error if not using supported Cake Version
34a871e
gep13 added a commit that referenced this issue Apr 23, 2019
@gep13
Merge branch 'feature/GH-306' into develop
6349d0a 
* feature/GH-306:
  (GH-306) Error if not using supported Cake Version
  (GH-306) Fix integration tests
  (GH-358) Update nuspec metadata
  (maint) Update to latest PS Bootstrapper
gep13 added a commit that referenced this issue Apr 23, 2019
@gep13
Merge branch 'release/1.0.0'
dfffcba 
* release/1.0.0: (360 commits)
  (maint) Change order of information logs
  (maint) Use correct version number format
  (build) Fix syntax error
  (GH-306) Error if not using supported Cake Version
  (GH-306) Fix integration tests
  (GH-358) Update nuspec metadata
  (maint) Update to latest PS Bootstrapper
  (GH-353) Change wording of notification messages
  (maint) Updated to latest Cake.Slack
  (GH-354) Changed to parse path te libgit2 before patching
  (GH-354) Updated to patch LibGit2Sharp.dll.config
  (GH-337) Update NUnit.ConsoleRunner reference from 3.4.1 to 3.10.0
  (GH-335) Update KuduSync.NET reference from 1.3.1 to 1.5.2
  (GH-332) Update Cake.Wyam reference from 1.7.4 to 2.2.4
  (GH-344) Update Wyam reference from 1.7.4 to 2.2.4
  (GH-342) Update OpenCover reference from 4.6.519 to 4.7.922
  (GH-328) Update Cake.Codecov reference from 0.4.0 to 0.5.0
  (GH-326) Update Fixie reference from 1.0.2 to 2.0.4
  (GH-327) Update JetBrains.ReSharper.CommandLineTools reference from 2018.2.3 to 2018.3.4
  (GH-329) Update Cake.Issues.Reporting.Generic reference from 0.6.1 to 0.6.2
  ...
cake-contrib-bot pushed a commit that referenced this issue Apr 23, 2019
@gep13
AppVeyor Publish: dfffcba
a5b8f49 
Merge branch 'release/1.0.0'

* release/1.0.0: (360 commits)
  (maint) Change order of information logs
  (maint) Use correct version number format
  (build) Fix syntax error
  (GH-306) Error if not using supported Cake Version
  (GH-306) Fix integration tests
  (GH-358) Update nuspec metadata
  (maint) Update to latest PS Bootstrapper
  (GH-353) Change wording of notification messages
  (maint) Updated to latest Cake.Slack
  (GH-354) Changed to parse path te libgit2 before patching
  (GH-354) Updated to patch LibGit2Sharp.dll.config
  (GH-337) Update NUnit.ConsoleRunner reference from 3.4.1 to 3.10.0
  (GH-335) Update KuduSync.NET reference from 1.3.1 to 1.5.2
  (GH-332) Update Cake.Wyam reference from 1.7.4 to 2.2.4
  (GH-344) Update Wyam reference from 1.7.4 to 2.2.4
  (GH-342) Update OpenCover reference from 4.6.519 to 4.7.922
  (GH-328) Update Cake.Codecov reference from 0.4.0 to 0.5.0
  (GH-326) Update Fixie reference from 1.0.2 to 2.0.4
  (GH-327) Update JetBrains.ReSharper.CommandLineTools reference from 2018.2.3 to 2018.3.4
  (GH-329) Update Cake.Issues.Reporting.Generic reference from 0.6.1 to 0.6.2
  ...
cake-contrib-bot pushed a commit that referenced this issue Apr 23, 2019
@gep13
AppVeyor Publish: dfffcba
227286e 
Merge branch 'release/1.0.0'

* release/1.0.0: (360 commits)
  (maint) Change order of information logs
  (maint) Use correct version number format
  (build) Fix syntax error
  (GH-306) Error if not using supported Cake Version
  (GH-306) Fix integration tests
  (GH-358) Update nuspec metadata
  (maint) Update to latest PS Bootstrapper
  (GH-353) Change wording of notification messages
  (maint) Updated to latest Cake.Slack
  (GH-354) Changed to parse path te libgit2 before patching
  (GH-354) Updated to patch LibGit2Sharp.dll.config
  (GH-337) Update NUnit.ConsoleRunner reference from 3.4.1 to 3.10.0
  (GH-335) Update KuduSync.NET reference from 1.3.1 to 1.5.2
  (GH-332) Update Cake.Wyam reference from 1.7.4 to 2.2.4
  (GH-344) Update Wyam reference from 1.7.4 to 2.2.4
  (GH-342) Update OpenCover reference from 4.6.519 to 4.7.922
  (GH-328) Update Cake.Codecov reference from 0.4.0 to 0.5.0
  (GH-326) Update Fixie reference from 1.0.2 to 2.0.4
  (GH-327) Update JetBrains.ReSharper.CommandLineTools reference from 2018.2.3 to 2018.3.4
  (GH-329) Update Cake.Issues.Reporting.Generic reference from 0.6.1 to 0.6.2
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@gep13 @bjorkstromm