Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error templates #992

Closed
1 of 3 tasks
ghost opened this issue Jan 7, 2024 · 1 comment · Fixed by #993
Closed
1 of 3 tasks

Error templates #992

ghost opened this issue Jan 7, 2024 · 1 comment · Fixed by #993
Milestone
5.x

Comments

@ghost
Copy link

ghost commented Jan 7, 2024

This is a (multiple allowed):

  • bug

  • enhancement

  • feature-discussion (RFC)

  • CakePHP Application Skeleton Version: 5.0.4.

What happened

Error templates use $error->params which are protected. It would be better to use $error->errorInfo maybe...

templates/Error/error400.php line 27, 29
templates/Error/error400.php line 27, 29
@dereuromark
Copy link
Member

See #970 also

@markstory markstory added this to the 5.x milestone Jan 8, 2024
ADmad added a commit that referenced this issue Feb 21, 2024
@ADmad
Clean up error templates.
4ec4573 
With debug enabled the WebExceptionRenderer switches the template to pdo_error.php,
so having checks for SQL query related stuff in debug mode is redundant.

Refs #970, closes #992.
@ADmad ADmad mentioned this issue Feb 21, 2024
Merged
ADmad added a commit that referenced this issue Feb 21, 2024
@ADmad
Clean up error templates.
17d517c 
With debug enabled the WebExceptionRenderer switches the template to pdo_error.php,
so having checks for SQL query related stuff in debug mode is redundant.

Refs #970, closes #992.
ADmad added a commit that referenced this issue Feb 21, 2024
@ADmad
Clean up error templates.
50ced3b 
With debug enabled the WebExceptionRenderer switches the template to pdo_error.php in case
of a PDOException, so having checks for SQL query related stuff in debug mode is redundant.

Refs #970, closes #992.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.x
Development

Successfully merging a pull request may close this issue.

Clean up error templates. cakephp/app
2 participants
@markstory @dereuromark