New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using \Cake\Http\ServerRequest|Response instead of \Cake\Network\* #399

Merged
merged 2 commits into from Dec 26, 2017

Conversation

Projects
None yet
5 participants
@gotoeveryone
Contributor

gotoeveryone commented Dec 26, 2017

bake task is using the following.

  • \Cake\Network\Request
  • \Cake\Network\Response

Changed it to use the following.

  • \Cake\Http\ServerRequest
  • \Cake\Http\Response
@@ -19,8 +19,8 @@
use Cake\Core\ConventionsTrait;
use Cake\Event\Event;
use Cake\Event\EventManager;
use Cake\Network\Request;
use Cake\Network\Response;
use Cake\Http\ServerRequest as Request;

This comment has been minimized.

@stickler-ci

stickler-ci Dec 26, 2017

Use classes must be in alphabetical order. Was expecting Cake\Http\Response

use Cake\Network\Request;
use Cake\Network\Response;
use Cake\Http\ServerRequest as Request;
use Cake\Http\Response;

This comment has been minimized.

@stickler-ci

stickler-ci Dec 26, 2017

Use classes must be in alphabetical order. Was expecting Cake\Http\ServerRequestRequest

@@ -20,8 +20,8 @@
use Cake\Core\Exception\Exception;
use Cake\Core\Plugin;
use Cake\Filesystem\Folder;
use Cake\Network\Request;
use Cake\Network\Response;
use Cake\Http\ServerRequest as Request;

This comment has been minimized.

@stickler-ci

stickler-ci Dec 26, 2017

Use classes must be in alphabetical order. Was expecting Cake\Http\Response

use Cake\Network\Request;
use Cake\Network\Response;
use Cake\Http\ServerRequest as Request;
use Cake\Http\Response;

This comment has been minimized.

@stickler-ci

stickler-ci Dec 26, 2017

Use classes must be in alphabetical order. Was expecting Cake\Http\ServerRequestRequest

@@ -21,8 +21,8 @@
use Bake\Test\TestCase\TestCase;
use Cake\Core\Configure;
use Cake\Core\Plugin;
use Cake\Network\Request;
use Cake\Network\Response;
use Cake\Http\ServerRequest as Request;

This comment has been minimized.

@stickler-ci

stickler-ci Dec 26, 2017

Use classes must be in alphabetical order. Was expecting Cake\Http\Response

use Cake\Network\Request;
use Cake\Network\Response;
use Cake\Http\ServerRequest as Request;
use Cake\Http\Response;

This comment has been minimized.

@stickler-ci

stickler-ci Dec 26, 2017

Use classes must be in alphabetical order. Was expecting Cake\Http\ServerRequestRequest

@@ -18,8 +18,8 @@
use Cake\Core\Configure;
use Cake\Core\Plugin;
use Cake\Event\Event;
use Cake\Network\Request;
use Cake\Network\Response;
use Cake\Http\ServerRequest as Request;

This comment has been minimized.

@stickler-ci

stickler-ci Dec 26, 2017

Use classes must be in alphabetical order. Was expecting Cake\Http\Response

use Cake\Network\Request;
use Cake\Network\Response;
use Cake\Http\ServerRequest as Request;
use Cake\Http\Response;

This comment has been minimized.

@stickler-ci

stickler-ci Dec 26, 2017

Use classes must be in alphabetical order. Was expecting Cake\Http\ServerRequestRequest

@codecov-io

This comment has been minimized.

codecov-io commented Dec 26, 2017

Codecov Report

Merging #399 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #399   +/-   ##
=========================================
  Coverage     92.41%   92.41%           
  Complexity      676      676           
=========================================
  Files            25       25           
  Lines          2176     2176           
=========================================
  Hits           2011     2011           
  Misses          165      165
Impacted Files Coverage Δ Complexity Δ
src/Shell/Task/BakeTemplateTask.php 100% <ø> (ø) 6 <0> (ø) ⬇️
src/Shell/Task/TestTask.php 95.51% <100%> (ø) 89 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d339c79...17547ae. Read the comment docs.

@dereuromark

This comment has been minimized.

Member

dereuromark commented Dec 26, 2017

Looks good.

@markstory markstory added this to the 1.5.x milestone Dec 26, 2017

@markstory markstory merged commit c849ffc into cakephp:master Dec 26, 2017

4 checks passed

codecov/patch 100% of diff hit (target 92.41%)
Details
codecov/project 92.41% (+0%) compared to fa49e71
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.

@gotoeveryone gotoeveryone deleted the gotoeveryone:fix/celltest-request-response branch May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment