New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using TableLocator instead of TableRegistry static method. #444

Merged
merged 1 commit into from May 8, 2018

Conversation

Projects
None yet
2 participants
@gotoeveryone
Contributor

gotoeveryone commented May 8, 2018

No description provided.

@codecov

This comment has been minimized.

codecov bot commented May 8, 2018

Codecov Report

Merging #444 into master will not change coverage.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #444   +/-   ##
=========================================
  Coverage     94.24%   94.24%           
  Complexity      685      685           
=========================================
  Files            26       26           
  Lines          2191     2191           
=========================================
  Hits           2065     2065           
  Misses          126      126
Impacted Files Coverage Δ Complexity Δ
src/Shell/Task/ControllerTask.php 100% <100%> (ø) 23 <0> (ø) ⬇️
src/Shell/Task/TemplateTask.php 100% <100%> (ø) 41 <0> (ø) ⬇️
src/Shell/Task/ModelTask.php 95.78% <80%> (ø) 157 <0> (ø) ⬇️
src/Shell/Task/TestTask.php 97.55% <80%> (ø) 89 <0> (ø) ⬇️
src/Shell/Task/FixtureTask.php 93.66% <85.71%> (ø) 69 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68db689...e3c08fb. Read the comment docs.

@markstory markstory merged commit 9d58b0f into cakephp:master May 8, 2018

4 of 5 checks passed

codecov/patch 87.5% of diff hit (target 94.24%)
Details
codecov/project 94.24% remains the same compared to 68db689
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
@markstory

This comment has been minimized.

Member

markstory commented May 8, 2018

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment