Permalink
Browse files

Add type hints in SchemaShell.

I'm trying to figure out what's going on in the failing travis builds.
  • Loading branch information...
1 parent 8d3cd6e commit 1d529c1dd2ede04ed84e18dd970b63f3555e1133 @markstory markstory committed Mar 1, 2013
@@ -305,7 +305,7 @@ protected function _loadSchema() {
* @param string $table
* @return void
*/
- protected function _create($Schema, $table = null) {
+ protected function _create(CakeSchema $Schema, $table = null) {
$db = ConnectionManager::getDataSource($this->Schema->connection);
$drop = $create = array();
@@ -395,7 +395,7 @@ protected function _update(&$Schema, $table = null) {
* @param CakeSchema $Schema
* @return void
*/
- protected function _run($contents, $event, &$Schema) {
+ protected function _run($contents, $event, CakeSchema $Schema) {
if (empty($contents)) {
$this->err(__d('cake_console', 'Sql could not be run'));
return;
@@ -471,8 +471,11 @@ public function testUpdateWithTable() {
);
$this->Shell->args = array('SchemaShellTest', 'articles');
$this->Shell->startup();
- $this->Shell->expects($this->any())->method('in')->will($this->returnValue('y'));
- $this->Shell->expects($this->once())->method('_run')
+ $this->Shell->expects($this->any())
+ ->method('in')
+ ->will($this->returnValue('y'));
+ $this->Shell->expects($this->once())
+ ->method('_run')
->with($this->arrayHasKey('articles'), 'update', $this->isInstanceOf('CakeSchema'));
$this->Shell->update();

0 comments on commit 1d529c1

Please sign in to comment.