Skip to content
Permalink
Browse files

Do not change session handler if session is active

Avoid notice "session_set_save_handler(): Cannot change save handler when session is active" on PHP 7.2
  • Loading branch information...
garas committed Oct 13, 2018
1 parent cb3034e commit 201b28bb1b7d21532170c8a2eae4ab526ea0ae73
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/Http/Session.php
@@ -290,7 +290,7 @@ public function engine($class = null, array $options = [])
*/
protected function setEngine(SessionHandlerInterface $handler)
{
if (!headers_sent()) {
if (!headers_sent() && session_status() !== \PHP_SESSION_ACTIVE) {
session_set_save_handler($handler, false);
}
@@ -535,7 +535,7 @@ public function destroy()
$this->start();
}
if (!$this->_isCLI && session_status() === PHP_SESSION_ACTIVE) {
if (!$this->_isCLI && session_status() === \PHP_SESSION_ACTIVE) {
session_destroy();
}

0 comments on commit 201b28b

Please sign in to comment.
You can’t perform that action at this time.