Permalink
Browse files

Renaming Configure var 'Security.cipher_seed' to 'Security.cipherSeed…

…'. Also added a srand() call at end of Security::cipher function to reset seed. Closes #73 , #183 , #218
  • Loading branch information...
1 parent 39dd15d commit 22073e33760fdf628d5a742ce7e71cd3b670053d @ADmad ADmad committed Jan 19, 2010
Showing with 7 additions and 5 deletions.
  1. +1 −1 app/config/core.php
  2. +1 −1 cake/console/templates/skel/config/core.php
  3. +2 −2 cake/libs/debugger.php
  4. +3 −1 cake/libs/security.php
View
@@ -200,7 +200,7 @@
/**
* A random numeric string (digits only) used to encrypt/decrypt strings.
*/
- Configure::write('Security.cipher_seed', '76859309657453542496749683645');
+ Configure::write('Security.cipherSeed', '76859309657453542496749683645');
/**
* Apply timestamps with the last modified time to static assets (js, css, images).
@@ -209,7 +209,7 @@
/**
* A random numeric string (digits only) used to encrypt/decrypt strings.
*/
- Configure::write('Security.cipher_seed', '76859309657453542496749683645');
+ Configure::write('Security.cipherSeed', '76859309657453542496749683645');
/**
* Compress CSS output by removing comments, whitespace, repeating tags, etc.
@@ -674,8 +674,8 @@ function checkSecurityKeys() {
trigger_error(__('Please change the value of \'Security.salt\' in app/config/core.php to a salt value specific to your application', true), E_USER_NOTICE);
}
- if (Configure::read('Security.cipher_seed') == '76859309657453542496749683645') {
- trigger_error(__('Please change the value of \'Security.cipher_seed\' in app/config/core.php to a numeric (digits only) seed value specific to your application', true), E_USER_NOTICE);
+ if (Configure::read('Security.cipherSeed') == '76859309657453542496749683645') {
+ trigger_error(__('Please change the value of \'Security.cipherSeed\' in app/config/core.php to a numeric (digits only) seed value specific to your application', true), E_USER_NOTICE);
}
}
@@ -174,7 +174,7 @@ function cipher($text, $key) {
return '';
}
- srand(Configure::read('Security.cipher_seed'));
+ srand(Configure::read('Security.cipherSeed'));
$out = '';
for ($i = 0; $i < strlen($text); $i++) {
@@ -184,6 +184,8 @@ function cipher($text, $key) {
$mask = rand(0, 255);
$out .= chr(ord(substr($text, $i, 1)) ^ $mask);
}
+
+ srand();
return $out;
}
}

0 comments on commit 22073e3

Please sign in to comment.