Permalink
Browse files

Merge pull request #971 from ceeram/typehint

Add type hinting to dispatch filters.

This should help provide more helpful errors when developers make mistakes.
  • Loading branch information...
2 parents e7c3034 + 5741ac1 commit 4025794b05262c4ea41b91d94460c7894e96a8c6 @markstory markstory committed Nov 24, 2012
@@ -66,7 +66,7 @@ public function implementedEvents() {
* keys in the data property.
* @return CakeResponse|boolean
**/
- public function beforeDispatch($event) {
+ public function beforeDispatch(CakeEvent $event) {
}
/**
@@ -81,6 +81,6 @@ public function beforeDispatch($event) {
* keys in the data property.
* @return mixed boolean to stop the event dispatching or null to continue
**/
- public function afterDispatch($event) {
+ public function afterDispatch(CakeEvent $event) {
}
}
@@ -40,7 +40,7 @@ class AssetDispatcher extends DispatcherFilter {
* @param CakeEvent $event containing the request and response object
* @return CakeResponse if the client is requesting a recognized asset, null otherwise
*/
- public function beforeDispatch($event) {
+ public function beforeDispatch(CakeEvent $event) {
$url = $event->data['request']->url;
if (strpos($url, '..') !== false || strpos($url, '.') === false) {
return;
@@ -77,7 +77,7 @@ public function beforeDispatch($event) {
* @param CakeEvent $event containing the request and response object
* @return CakeResponse if the client is requesting a recognized asset, null otherwise
*/
- protected function _filterAsset($event) {
+ protected function _filterAsset(CakeEvent $event) {
$url = $event->data['request']->url;
$response = $event->data['response'];
$filters = Configure::read('Asset.filter');
@@ -36,7 +36,7 @@ class CacheDispatcher extends DispatcherFilter {
* @param CakeEvent $event containing the request and response object
* @return CakeResponse with cached content if found, null otherwise
*/
- public function beforeDispatch($event) {
+ public function beforeDispatch(CakeEvent $event) {
if (Configure::read('Cache.check') !== true) {
return;
}

0 comments on commit 4025794

Please sign in to comment.