Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fix web runner showing fails as passes when show_passes is on.

Fixes #3035
  • Loading branch information...
commit 46f8de72a2be00ab10ebbf6536a50b4982f34701 1 parent 8fc5726
@markstory markstory authored
Showing with 3 additions and 0 deletions.
  1. +3 −0  lib/Cake/TestSuite/Reporter/CakeBaseReporter.php
View
3  lib/Cake/TestSuite/Reporter/CakeBaseReporter.php
@@ -201,6 +201,9 @@ public function startTest(PHPUnit_Framework_Test $test) {
*/
public function endTest(PHPUnit_Framework_Test $test, $time) {
$this->numAssertions += $test->getNumAssertions();
+ if ($test->hasFailed()) {
+ return;
+ }
$this->paintPass($test, $time);
}

1 comment on commit 46f8de7

@lsiden

Thank you, Mark!

Please sign in to comment.
Something went wrong with that request. Please try again.