Skip to content
This repository
Browse code

Fix web runner showing fails as passes when show_passes is on.

Fixes #3035
  • Loading branch information...
commit 46f8de72a2be00ab10ebbf6536a50b4982f34701 1 parent 8fc5726
Mark Story authored July 13, 2012
3  lib/Cake/TestSuite/Reporter/CakeBaseReporter.php
@@ -201,6 +201,9 @@ public function startTest(PHPUnit_Framework_Test $test) {
201 201
  */
202 202
 	public function endTest(PHPUnit_Framework_Test $test, $time) {
203 203
 		$this->numAssertions += $test->getNumAssertions();
  204
+		if ($test->hasFailed()) {
  205
+			return;
  206
+		}
204 207
 		$this->paintPass($test, $time);
205 208
 	}
206 209
 

1 note on commit 46f8de7

Larry Siden

Thank you, Mark!

Please sign in to comment.
Something went wrong with that request. Please try again.