Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Adding tests for ConnectionManager, and fixing a missing return value…

… for ConnectionManager::loadDataSource().
  • Loading branch information...
commit 4bf5244073ec81c509311cd15a6e668d7dfaa436 1 parent cd64043
@jperras jperras authored
View
2  cake/libs/model/connection_manager.php
@@ -179,6 +179,8 @@ function loadDataSource($connName) {
trigger_error(sprintf($error, $conn['filename']), E_USER_ERROR);
return null;
}
+
+ return true;
}
/**
* Gets a list of class and file names associated with the user-defined DataSource connections
View
180 cake/tests/cases/libs/model/connection_manager.test.php
@@ -0,0 +1,180 @@
+<?php
+
+/**
+ * Connection Manager tests
+ *
+ *
+ * PHP versions 4 and 5
+ *
+ * Copyright 2005-2009, Cake Software Foundation, Inc. (http://www.cakefoundation.org)
+ *
+ * Licensed under The Open Group Test Suite License
+ * Redistributions of files must retain the above copyright notice.
+ *
+ * @filesource
+ * @copyright Copyright 2005-2009, Cake Software Foundation, Inc. (http://www.cakefoundation.org)
+ * @link https://trac.cakephp.org/wiki/Developement/TestSuite CakePHP(tm) Tests
+ * @package cake
+ * @subpackage cake.tests.cases.libs
+ * @since CakePHP(tm) v 1.2.0.5550
+ * @license http://www.opensource.org/licenses/opengroup.php The Open Group Test Suite License
+ */
+App::import('Core', 'ConnectionManager');
+
+/**
+ * ConnectionManagerTest
+ *
+ * @package cake
+ * @subpackage cake.tests.cases.models
+ */
+class ConnectionManagerTest extends CakeTestCase {
+
+/**
+ * setUp method
+ *
+ * @access public
+ * @return void
+ */
+ function setUp() {
+ $this->ConnectionManager = ConnectionManager::getInstance();
+ }
+
+/**
+ * tearDown method
+ *
+ * @access public
+ * @return void
+ */
+ function tearDown() {
+ unset($this->ConnectionManager);
+ }
+
+/**
+ * testInstantiation method
+ *
+ * @access public
+ * @return void
+ */
+ function testInstantiation() {
+ $this->assertTrue(is_a($this->ConnectionManager, 'ConnectionManager'));
+ }
+
+/**
+ * testEnumConnectionObjects method
+ *
+ * @access public
+ * @return void
+ */
+ function testEnumConnectionObjects() {
+ $sources = ConnectionManager::enumConnectionObjects();
+ $this->assertTrue(count($sources) >= 1);
+
+ $connections = array('default', 'test', 'test_suite');
+ $this->assertTrue(count(array_intersect(array_keys($sources), $connections)) >= 1);
+ }
+
+/**
+ * testGetDataSource method
+ *
+ * @access public
+ * @return void
+ */
+ function testGetDataSource() {
+ $connections = ConnectionManager::enumConnectionObjects();
+ $this->assertTrue(count(array_keys($connections) >= 1));
+
+ $source = ConnectionManager::getDataSource(key($connections));
+ $this->assertTrue(is_object($source));
+
+ }
+
+/**
+ * testSourceList method
+ *
+ * @access public
+ * @return void
+ */
+ function testSourceList() {
+ $sources = ConnectionManager::sourceList();
+ $this->assertTrue(count($sources) >= 1);
+
+ $connections = array('default', 'test', 'test_suite');
+ $this->assertTrue(count(array_intersect($sources, $connections)) >= 1);
+ }
+
+/**
+ * testGetSourceName method
+ *
+ * @access public
+ * @return void
+ */
+ function testGetSourceName() {
+ $connections = ConnectionManager::enumConnectionObjects();
+ $name = key($connections);
+ $source = ConnectionManager::getDataSource($name);
+ $result = ConnectionManager::getSourceName($source);
+
+ $this->assertEqual($result, $name);
+ }
+
+/**
+ * testLoadDataSource method
+ *
+ * @access public
+ * @return void
+ */
+ function testLoadDataSource() {
+ $connections = array(
+ array('classname' => 'DboMysql', 'filename' => 'dbo' . DS . 'dbo_mysql'),
+ array('classname' => 'DboMysqli', 'filename' => 'dbo' . DS . 'dbo_mysqli'),
+ array('classname' => 'DboMssql', 'filename' => 'dbo' . DS . 'dbo_mssql'),
+ array('classname' => 'DboOracle', 'filename' => 'dbo' . DS . 'dbo_oracle'),
+ );
+
+ foreach ($connections as $connection) {
+ $exists = class_exists($connection['classname']);
+ $loaded = ConnectionManager::loadDataSource($connection);
+ $this->assertEqual($loaded, !$exists, "%s Failed loading the {$connection['classname']} datasource");
+ }
+
+ $connection = array('classname' => 'NonExistentDataSource', 'filename' => 'non_existent');
+ $this->expectError(new PatternExpectation('/Unable to load DataSource file/i'));
+
+ $loaded = ConnectionManager::loadDataSource($connection);
+ $this->assertEqual($loaded, null);
+ }
+
+/**
+ * testCreateDataSource method
+ *
+ * @access public
+ * @return void
+ */
+ function testCreateDataSourceWithIntegrationTests() {
+ $name = 'test_created_connection';
+
+ $connections = ConnectionManager::enumConnectionObjects();
+ $this->assertTrue(count(array_keys($connections) >= 1));
+
+ $source = ConnectionManager::getDataSource(key($connections));
+ $this->assertTrue(is_object($source));
+
+ $config = $source->config;
+ $connection = ConnectionManager::create($name, $config);
+
+ $this->assertTrue(is_object($connection));
+ $this->assertEqual($name, $connection->configKeyName);
+ $this->assertEqual($name, ConnectionManager::getSourceName($connection));
+
+ $source = ConnectionManager::create(null, array());
+ $this->assertEqual($source, null);
+
+ $source = ConnectionManager::create('another_test', array());
+ $this->assertEqual($source, null);
+
+ $config = array('classname' => 'DboMysql', 'filename' => 'dbo' . DS . 'dbo_mysql');
+ $source = ConnectionManager::create(null, $config);
+ $this->assertEqual($source, null);
+ }
+}
+?>
Please sign in to comment.
Something went wrong with that request. Please try again.