Permalink
Browse files

Removed comparison method

  • Loading branch information...
1 parent 1202658 commit 5e896aa94ae736350add2ac902dace0a8ad42997 Mike Gibson committed Mar 10, 2014
Showing with 3 additions and 14 deletions.
  1. +3 −14 lib/Cake/Routing/Route/CakeRoute.php
@@ -518,10 +518,10 @@ protected function _writeUrl($params) {
$out = $this->template;
$search = $replace = array();
- $keys = $this->keys;
- // Sort the keys in reverse order by length to prevent mismatches
- uasort($keys, array($this, '_sortKeys'));
+ $lengths = array_map('strlen', $this->keys);
+ $keys = array_combine($lengths, $this->keys);
+ krsort($keys);
foreach ($keys as $key) {
$string = null;
@@ -542,15 +542,4 @@ protected function _writeUrl($params) {
return $out;
}
- /**
- * Comparison method for sorting keys in reverse order by length.
- *
- * @param $a
- * @param $b
- * @return int
- */
- protected function _sortKeys($a, $b) {
- return strlen($a) > strlen($b) ? -1 : 1;
- }
-
}

0 comments on commit 5e896aa

Please sign in to comment.