Skip to content
Browse files

fix coding standards, remove break after return/continue

  • Loading branch information...
1 parent e02eab0 commit 6d0e32e642055d356e9b5676d4289ba74bf977ea @ceeram ceeram committed Nov 15, 2012
Showing with 0 additions and 25 deletions.
  1. +0 −1 lib/Cake/Model/Permission.php
  2. +0 −20 lib/Cake/Test/Case/Model/BehaviorCollectionTest.php
  3. +0 −4 lib/Cake/basics.php
View
1 lib/Cake/Model/Permission.php
@@ -146,7 +146,6 @@ public function check($aro, $aco, $action = "*") {
return false;
case 0:
continue;
- break;
case 1:
return true;
}
View
20 lib/Cake/Test/Case/Model/BehaviorCollectionTest.php
@@ -66,15 +66,12 @@ public function beforeFind(Model $model, $query) {
switch ($settings['beforeFind']) {
case 'on':
return false;
- break;
case 'test':
return null;
- break;
case 'modify':
$query['fields'] = array($model->alias . '.id', $model->alias . '.name', $model->alias . '.mytime');
$query['recursive'] = -1;
return $query;
- break;
}
}
@@ -94,16 +91,12 @@ public function afterFind(Model $model, $results, $primary) {
switch ($settings['afterFind']) {
case 'on':
return array();
- break;
case 'test':
return true;
- break;
case 'test2':
return null;
- break;
case 'modify':
return Hash::extract($results, "{n}.{$model->alias}");
- break;
}
}
@@ -121,14 +114,11 @@ public function beforeSave(Model $model) {
switch ($settings['beforeSave']) {
case 'on':
return false;
- break;
case 'test':
return true;
- break;
case 'modify':
$model->data[$model->alias]['name'] .= ' modified before';
return true;
- break;
}
}
@@ -157,7 +147,6 @@ public function afterSave(Model $model, $created) {
break;
case 'test2':
return false;
- break;
case 'modify':
$model->data[$model->alias]['name'] .= ' ' . $string;
break;
@@ -179,18 +168,14 @@ public function beforeValidate(Model $model) {
case 'on':
$model->invalidate('name');
return true;
- break;
case 'test':
return null;
- break;
case 'whitelist':
$this->_addToWhitelist($model, array('name'));
return true;
- break;
case 'stop':
$model->invalidate('name');
return false;
- break;
}
}
@@ -209,11 +194,9 @@ public function afterValidate(Model $model) {
switch ($settings['afterValidate']) {
case 'on':
return false;
- break;
case 'test':
$model->data = array('foo');
return true;
- break;
}
}
@@ -232,17 +215,14 @@ public function beforeDelete(Model $model, $cascade = true) {
switch ($settings['beforeDelete']) {
case 'on':
return false;
- break;
case 'test':
return null;
- break;
case 'test2':
echo 'beforeDelete success';
if ($cascade) {
echo ' (cascading) ';
}
return true;
- break;
}
}
View
4 lib/Cake/basics.php
@@ -311,13 +311,10 @@ function env($key) {
$offset = 4;
}
return substr($filename, 0, -(strlen($name) + $offset));
- break;
case 'PHP_SELF':
return str_replace(env('DOCUMENT_ROOT'), '', env('SCRIPT_FILENAME'));
- break;
case 'CGI_MODE':
return (PHP_SAPI === 'cgi');
- break;
case 'HTTP_BASE':
$host = env('HTTP_HOST');
$parts = explode('.', $host);
@@ -357,7 +354,6 @@ function env($key) {
}
array_shift($parts);
return '.' . implode('.', $parts);
- break;
}
return null;
}

0 comments on commit 6d0e32e

Please sign in to comment.
Something went wrong with that request. Please try again.