Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Add missing return.

  • Loading branch information...
commit 6d80d6a3cbc89cddaf30fd051d4d74a4615cde83 1 parent 8ca92a1
@markstory markstory authored
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/Cake/Console/Command/ConsoleShell.php
View
2  lib/Cake/Console/Command/ConsoleShell.php
@@ -439,7 +439,7 @@ protected function _columns($command) {
*/
protected function _routesReload() {
if (!$this->_loadRoutes()) {
- $this->err(__d('cake_console', "There was an error loading the routes config. Please check that the file exists and is free of parse errors."));
+ return $this->err(__d('cake_console', "There was an error loading the routes config. Please check that the file exists and is free of parse errors."));
@dereuromark Collaborator

error() would halt - would that be better instead of err() - which would continue - maybe?

@markstory Owner

The code wants to continue as it is an interactive 'console'

@dereuromark Collaborator

All right :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
}
$this->out(__d('cake_console', "Routes configuration reloaded, %d routes connected", count(Router::$routes)));
}
@dereuromark

error() would halt - would that be better instead of err() - which would continue - maybe?

@markstory

The code wants to continue as it is an interactive 'console'

Please sign in to comment.
Something went wrong with that request. Please try again.