Skip to content
Permalink
Browse files

default value null makes more sense. add test cases for false.

  • Loading branch information...
dereuromark committed Oct 12, 2012
1 parent 57681ff commit 7bf08fdcc724ef203df8a5fb92bc495e72ee4d65
Showing with 20 additions and 1 deletion.
  1. +12 −0 lib/Cake/Test/Case/BasicsTest.php
  2. +7 −0 lib/Cake/Test/Case/Utility/DebuggerTest.php
  3. +1 −1 lib/Cake/basics.php
@@ -825,6 +825,18 @@ public function testDebug() {
########## DEBUG ##########
'<div>this-is-a-test</div>'
###########################
EXPECTED;
$expected = sprintf($expected, str_replace(CAKE_CORE_INCLUDE_PATH, '', __FILE__), __LINE__ - 8);
$this->assertEquals($expected, $result);
ob_start();
debug(false, false, false);
$result = ob_get_clean();
$expected = <<<EXPECTED
########## DEBUG ##########
false
###########################
EXPECTED;
$expected = sprintf($expected, str_replace(CAKE_CORE_INCLUDE_PATH, '', __FILE__), __LINE__ - 8);
$this->assertEquals($expected, $result);
@@ -391,6 +391,13 @@ public function testExportVar() {
[maximum depth reached]
)
)
TEXT;
$this->assertTextEquals($expected, $result);
$data = false;
$result = Debugger::exportVar($data);
$expected = <<<TEXT
false
TEXT;
$this->assertTextEquals($expected, $result);
}
@@ -75,7 +75,7 @@ function config() {
* @link http://book.cakephp.org/2.0/en/development/debugging.html#basic-debugging
* @link http://book.cakephp.org/2.0/en/core-libraries/global-constants-and-functions.html#debug
*/
function debug($var = false, $showHtml = null, $showFrom = true) {
function debug($var = null, $showHtml = null, $showFrom = true) {
if (Configure::read('debug') > 0) {
App::uses('Debugger', 'Utility');
$file = '';

0 comments on commit 7bf08fd

Please sign in to comment.
You can’t perform that action at this time.