Skip to content
Permalink
Browse files

Fixing issues in JqueryEngineHelper where eval()'ed responses wouldn'…

…t run code contained inside $js->domReady() due to implementation differences between $(document).ready() and $(document).bind('ready'). Tests updated.
  • Loading branch information...
markstory committed Jan 29, 2010
1 parent 3836592 commit 832b15ba3eb050aab9c2dd29648c3a0183be6548
@@ -178,15 +178,19 @@ function event($type, $callback, $options = array()) {
}
/**
* Create a domReady event. For jQuery
* Create a domReady event. For jQuery. This method does not
* bind a 'traditional event' as `$(document).bind('ready', fn)`
* Works in an entirely different fashion than `$(document).ready()`
* The first will not run the function when eval()'d as part of a response
* The second will. Because of the way that ajax pagination is done
* `$().ready()` is used.
*
* @param string $functionBody The code to run on domReady
* @return string completed domReady method
* @access public
*/
function domReady($functionBody) {
$this->get('document');
return $this->event('ready', $functionBody, array('stop' => false));
return $this->jQueryObject . '(document).ready(function () {' . $functionBody . '});';
}
/**
@@ -89,7 +89,7 @@ function testEvent() {
*/
function testDomReady() {
$result = $this->Jquery->domReady('foo.name = "bar";');
$expected = '$(document).bind("ready", function (event) {foo.name = "bar";});';
$expected = '$(document).ready(function () {foo.name = "bar";});';
$this->assertEqual($result, $expected);
}

0 comments on commit 832b15b

Please sign in to comment.
You can’t perform that action at this time.