Permalink
Browse files

Loop instead of duplicate code

  • Loading branch information...
1 parent c01aacf commit 84dcd30730439d20ff84855b21f3a67fb62ef588 @tigrang tigrang committed Aug 6, 2013
Showing with 14 additions and 18 deletions.
  1. +14 −18 lib/Cake/Utility/Debugger.php
@@ -591,24 +591,20 @@ protected static function _object($var, $depth, $indent) {
if (version_compare(PHP_VERSION, '5.3.0') >= 0) {
$ref = new ReflectionObject($var);
- $reflectionProperties = $ref->getProperties(ReflectionProperty::IS_PROTECTED);
- foreach ($reflectionProperties as $reflectionProperty) {
- $reflectionProperty->setAccessible(true);
- $property = $reflectionProperty->getValue($var);
-
- $value = self::_export($property, $depth - 1, $indent);
- $key = $reflectionProperty->name;
- $props[] = "[protected] $key => " . $value;
- }
-
- $reflectionProperties = $ref->getProperties(ReflectionProperty::IS_PRIVATE);
- foreach ($reflectionProperties as $reflectionProperty) {
- $reflectionProperty->setAccessible(true);
- $property = $reflectionProperty->getValue($var);
-
- $value = self::_export($property, $depth - 1, $indent);
- $key = $reflectionProperty->name;
- $props[] = "[private] $key => " . $value;
+ $filters = array(
+ ReflectionProperty::IS_PROTECTED => 'protected',
+ ReflectionProperty::IS_PRIVATE => 'private',
+ );
+ foreach ($filters as $filter => $visibility) {
+ $reflectionProperties = $ref->getProperties($filter);
+ foreach ($reflectionProperties as $reflectionProperty) {
+ $reflectionProperty->setAccessible(true);
+ $property = $reflectionProperty->getValue($var);
+
+ $value = self::_export($property, $depth - 1, $indent);
+ $key = $reflectionProperty->name;
+ $props[] = sprintf('[%s] %s => %s', $visibility, $key, $value);
+ }
}
}

0 comments on commit 84dcd30

Please sign in to comment.