Skip to content
Permalink
Browse files

Fixing problems found in code review

  • Loading branch information...
lorenzo committed Dec 28, 2013
1 parent 49e3ecc commit 9426ccdb08bf29e06d9aba0473727a94bc488938
Showing with 5 additions and 3 deletions.
  1. +5 −2 Cake/ORM/ResultSet.php
  2. +0 −1 Cake/Test/TestCase/ORM/ResultSetTest.php
@@ -111,7 +111,7 @@ class ResultSet implements Countable, Iterator, Serializable, JsonSerializable {
*
* @var boolean
*/
protected $_useBuffering;
protected $_useBuffering = true;
/**
* Constructor
@@ -212,7 +212,10 @@ public function valid() {
* @return string Serialized object
*/
public function serialize() {
return serialize($this->toArray());
while($this->valid()) {
$this->next();
}
return serialize($this->_results);
}
/**
@@ -87,7 +87,6 @@ public function testRewindStreaming() {
}
}
/**
* An integration test for testing serialize and unserialize features.
*

0 comments on commit 9426ccd

Please sign in to comment.
You can’t perform that action at this time.