Fixing FormAuthenticateTest for Sqlsrv

cakephp · Jun 21, 2011 · a34358f · a34358f
1 parent f1108b2
commit a34358f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 16 deletions.
diff --git a/lib/Cake/Model/Datasource/Database/Sqlserver.php b/lib/Cake/Model/Datasource/Database/Sqlserver.php
@@ -517,20 +517,7 @@ public function renderStatement($type, $data) {
 					$offset = intval($offset[1]) + intval($limitVal[1]);
 					$rOrder = $this->__switchSort($order);
 					list($order2, $rOrder) = array($this->__mapFields($order), $this->__mapFields($rOrder));
-					$limit2 = str_replace('TOP', '', $limit);
-					if (!$order) {
-						$order = 'ORDER BY (SELECT NULL)';
-					}
-
-					$pagination = "
-						SELECT {$limit} * FROM (
-							SELECT {$fields}, ROW_NUMBER() OVER ({$order}) AS ssma\$rownum
-							FROM {$table} {$alias} {$joins} {$conditions} {$group}
-						) AS ssma\$sub1
-						WHERE ssma\$sub1.[ssma\$rownum] > {$limit2}
-						ORDER BY ssma\$sub1.[ssma\$rownum]
-					";
-					return $pagination;
+					return "SELECT * FROM (SELECT {$limit} * FROM (SELECT TOP {$offset} {$fields} FROM {$table} {$alias} {$joins} {$conditions} {$group} {$order}) AS Set1 {$rOrder}) AS Set2 {$order2}";
 				} else {
 					return "SELECT {$limit} {$fields} FROM {$table} {$alias} {$joins} {$conditions} {$group} {$order}";
 				}

diff --git a/lib/Cake/Test/Case/Console/Command/Task/ProjectTaskTest.php b/lib/Cake/Test/Case/Console/Command/Task/ProjectTaskTest.php
@@ -245,7 +245,7 @@ public function testCakeAdmin() {
 		$this->assertTrue($result);
 
 		$this->assertEqual(Configure::read('Routing.prefixes'), array('my_prefix'));
-		$file->delete();
+		@$file->delete();
 	}
 
 /**

diff --git a/lib/Cake/Test/Case/Controller/Component/Auth/FormAuthenticateTest.php b/lib/Cake/Test/Case/Controller/Component/Auth/FormAuthenticateTest.php
@@ -44,7 +44,8 @@ public function setUp() {
 			'userModel' => 'User'
 		));
 		$password = Security::hash('password', null, true);
-		ClassRegistry::init('User')->updateAll(array('password' => '"' . $password . '"'));
+		$User = ClassRegistry::init('User');
+		$User->updateAll(array('password' => $User->getDataSource()->value($password)));
 		$this->response = $this->getMock('CakeResponse');
 	}