Skip to content
Permalink
Browse files

Make sure the line that will be overwritten in the CLI ProgressHelper…

… does not have a new line feed

Otherwise, it is impossible to be sure that the line that will be overwritten can be without any
visual glitch. Before this change, visual glitch appeared when using Putty on Windows.
  • Loading branch information...
HavokInspiration committed Feb 8, 2016
1 parent 4c3cc0b commit a6450b00b75d1e3070147e3d6c81cd993e4943a0
Showing with 4 additions and 0 deletions.
  1. +2 −0 src/Shell/Helper/ProgressHelper.php
  2. +2 −0 tests/TestCase/Shell/Helper/ProgressHelperTest.php
@@ -69,6 +69,8 @@ public function output($args)
$this->init($args);
$callback = $args['callback'];
$this->_io->out('', 0);
while ($this->_progress < $this->_total) {
$callback($this);
$this->draw();
@@ -60,6 +60,7 @@ public function testOutputSuccess()
$progress->increment(20);
}]);
$expected = [
'',
'',
'==============> 20%',
'',
@@ -90,6 +91,7 @@ public function testOutputSuccessOptions()
}
]);
$expected = [
'',
'',
'==> 20%',
'',

0 comments on commit a6450b0

Please sign in to comment.
You can’t perform that action at this time.