Set umask when creating cache file

Fixes #2080
cakephp · Oct 12, 2011 · b4e3c8a · b4e3c8a
1 parent 6fe24a4
commit b4e3c8a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/cake/libs/cache/file.php b/cake/libs/cache/file.php
@@ -138,9 +138,12 @@ function write($key, &$data, $duration) {
 
 		$expires = time() + $duration;
 		$contents = $expires . $lineBreak . $data . $lineBreak;
+		$old = umask(0);
+		$handle = fopen($this->_File->path, 'a');
+		umask($old);
 
-		if (!$handle = fopen($this->_File->path, 'a')) {
+		if (!$handle) {
-		    return false;
+			return false;
 		}
 
 		if ($this->settings['lock']) {