Permalink
Browse files

Add OK or Successful HTTP codes 200-206 to HttpResponse::isOK(). Fixes

  • Loading branch information...
1 parent 6e4d522 commit bcdbdc810849ce1f759d6517819f09f844eb94c5 @uzyn uzyn committed Jan 15, 2013
Showing with 28 additions and 4 deletions.
  1. +2 −2 lib/Cake/Network/Http/HttpResponse.php
  2. +26 −2 lib/Cake/Test/Case/Network/Http/HttpResponseTest.php
@@ -116,12 +116,12 @@ public function getHeader($name, $headers = null) {
}
/**
- * If return is 200 (OK)
+ * If return is a valid 2xx (OK or Successful)
*
* @return boolean
*/
public function isOk() {
- return $this->code == 200;
+ return in_array($this->code, array(200, 201, 202, 203, 204, 205, 206));
}
/**
@@ -157,12 +157,36 @@ public function testIsOk() {
$this->assertFalse($this->HttpResponse->isOk());
$this->HttpResponse->code = -1;
$this->assertFalse($this->HttpResponse->isOk());
- $this->HttpResponse->code = 201;
- $this->assertFalse($this->HttpResponse->isOk());
$this->HttpResponse->code = 'what?';
$this->assertFalse($this->HttpResponse->isOk());
$this->HttpResponse->code = 200;
$this->assertTrue($this->HttpResponse->isOk());
+ $this->HttpResponse->code = 201;
+ $this->assertTrue($this->HttpResponse->isOk());
+ $this->HttpResponse->code = 202;
+ $this->assertTrue($this->HttpResponse->isOk());
+ $this->HttpResponse->code = 203;
+ $this->assertTrue($this->HttpResponse->isOk());
+ $this->HttpResponse->code = 204;
+ $this->assertTrue($this->HttpResponse->isOk());
+ $this->HttpResponse->code = 205;
+ $this->assertTrue($this->HttpResponse->isOk());
+ $this->HttpResponse->code = 206;
+ $this->assertTrue($this->HttpResponse->isOk());
+ $this->HttpResponse->code = 207;
+ $this->assertFalse($this->HttpResponse->isOk());
+ $this->HttpResponse->code = 208;
+ $this->assertFalse($this->HttpResponse->isOk());
+ $this->HttpResponse->code = 209;
+ $this->assertFalse($this->HttpResponse->isOk());
+ $this->HttpResponse->code = 210;
+ $this->assertFalse($this->HttpResponse->isOk());
+ $this->HttpResponse->code = 226;
+ $this->assertFalse($this->HttpResponse->isOk());
+ $this->HttpResponse->code = 288;
+ $this->assertFalse($this->HttpResponse->isOk());
+ $this->HttpResponse->code = 301;
+ $this->assertFalse($this->HttpResponse->isOk());
}
/**

0 comments on commit bcdbdc8

Please sign in to comment.