Skip to content
This repository
Browse code

Correct convention with public visibility

  • Loading branch information...
commit c20285952371ac1e87b2653724ea922830be3ff6 1 parent c6449f6
Kyle Robinson Young authored February 23, 2012
4  lib/Cake/Test/Case/Network/CakeRequestTest.php
@@ -808,7 +808,7 @@ public function testAddDetector() {
808 808
 		$_SERVER['HTTP_USER_AGENT'] = 'iPhone 3.0';
809 809
 		$this->assertTrue($request->isMobile());
810 810
 
811  
-		$request->addDetector('callme', array('env' => 'TEST_VAR', 'callback' => array($this, '_detectCallback')));
  811
+		$request->addDetector('callme', array('env' => 'TEST_VAR', 'callback' => array($this, 'detectCallback')));
812 812
 
813 813
 		$request->addDetector('index', array('param' => 'action', 'value' => 'index'));
814 814
 		$request->params['action'] = 'index';
@@ -829,7 +829,7 @@ public function testAddDetector() {
829 829
  *
830 830
  * @return void
831 831
  */
832  
-	public function _detectCallback($request) {
  832
+	public function detectCallback($request) {
833 833
 		return $request->return == true;
834 834
 	}
835 835
 
6  lib/Cake/Test/Case/TestSuite/CakeTestFixtureTest.php
@@ -400,7 +400,7 @@ public function testInsert() {
400 400
 		$Fixture = new CakeTestFixtureTestFixture();
401 401
 		$this->criticDb->expects($this->atLeastOnce())
402 402
 			->method('insertMulti')
403  
-			->will($this->returnCallback(array($this, '_insertCallback')));
  403
+			->will($this->returnCallback(array($this, 'insertCallback')));
404 404
 
405 405
 		$return = $Fixture->insert($this->criticDb);
406 406
 		$this->assertTrue(!empty($this->insertMulti));
@@ -424,7 +424,7 @@ public function testInsert() {
424 424
  * @param string $values
425 425
  * @return boolean true
426 426
  */
427  
-	public function _insertCallback($table, $fields, $values) {
  427
+	public function insertCallback($table, $fields, $values) {
428 428
 		$this->insertMulti['table'] = $table;
429 429
 		$this->insertMulti['fields'] = $fields;
430 430
 		$this->insertMulti['values'] = $values;
@@ -440,7 +440,7 @@ public function testInsertStrings() {
440 440
 		$Fixture = new StringsTestFixture();
441 441
 		$this->criticDb->expects($this->atLeastOnce())
442 442
 			->method('insertMulti')
443  
-			->will($this->returnCallback(array($this, '_insertCallback')));
  443
+			->will($this->returnCallback(array($this, 'insertCallback')));
444 444
 
445 445
 		$return = $Fixture->insert($this->criticDb);
446 446
 		$this->assertTrue($this->criticDb->fullDebug);

0 notes on commit c202859

Please sign in to comment.
Something went wrong with that request. Please try again.