Permalink
Browse files

Removing ob_start() calls from cake_reporter. Significantly reduces m…

…emory usage of test suite. Fixes #5972

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7982 3807eeeb-6ff5-0310-8944-8be069107fe0
  • Loading branch information...
markstory committed Jan 14, 2009
1 parent 52318f9 commit c4fe08415b7943d85ee7ded552648d7a868ac26e
Showing with 0 additions and 8 deletions.
  1. +0 −8 cake/tests/lib/cake_reporter.php
@@ -54,7 +54,6 @@ function CakeHtmlReporter($character_set = 'ISO-8859-1') {
*/
function paintHeader($testName) {
$this->sendNoCacheHeaders();
- ob_start();
echo "<h2>$testName</h2>\n";
echo "<ul class='tests'>\n";
}
@@ -82,7 +81,6 @@ function sendNoCacheHeaders() {
*/
function paintFooter($test_name) {
$colour = ($this->getFailCount() + $this->getExceptionCount() > 0 ? "red" : "green");
- ob_start();
echo "</ul>\n";
echo "<div style=\"";
echo "padding: 8px; margin: 1em 0; background-color: $colour; color: white;";
@@ -104,7 +102,6 @@ function paintFooter($test_name) {
* @access public
*/
function paintFail($message) {
- ob_start();
parent::paintFail($message);
echo "<li class='fail'>\n";
echo "<span>Failed</span>";
@@ -123,7 +120,6 @@ function paintFail($message) {
* @access public
*/
function paintPass($message) {
- ob_start();
parent::paintPass($message);
if ($this->_show_passes) {
@@ -142,7 +138,6 @@ function paintPass($message) {
* @access public
*/
function paintError($message) {
- ob_start();
parent::paintError($message);
echo "<li class='error'>\n";
echo "<span>Error</span>";
@@ -158,7 +153,6 @@ function paintError($message) {
* @access public
*/
function paintException($exception) {
- ob_start();
parent::paintException($exception);
echo "<li class='fail'>\n";
echo "<span>Exception</span>";
@@ -178,7 +172,6 @@ function paintException($exception) {
* @access public
*/
function paintSkip($message) {
- ob_start();
parent::paintSkip($message);
echo "<li class='skipped'>\n";
echo "<span>Skipped</span> ";
@@ -191,7 +184,6 @@ function paintSkip($message) {
* @access public
*/
function paintFormattedMessage($message) {
- ob_start();
echo '<pre>' . $this->_htmlEntities($message) . '</pre>';
}
/**

0 comments on commit c4fe084

Please sign in to comment.