Skip to content
Permalink
Browse files

Rename method so they don't cause E_STRICT errors.

Fixes #3882
  • Loading branch information...
markstory committed Jun 18, 2013
1 parent a830750 commit d2ad9c581a2bb2444732e5bd5340f29e4d9c05bc
Showing with 4 additions and 4 deletions.
  1. +4 −4 lib/Cake/Console/Command/UpgradeShell.php
@@ -250,7 +250,7 @@ public function namespaces() {
*
* @return void
*/
public function log() {
public function log_config() {

This comment has been minimized.

Copy link
@ADmad

ADmad Jun 18, 2013

Member

Using underscored function names will make phpcs unhappy 😄

This comment has been minimized.

Copy link
@markstory

markstory Jun 18, 2013

Author Member

I think we disabled that lint check in controllers and shells.

This comment has been minimized.

Copy link
@ADmad

ADmad Jun 19, 2013

Member

Oh, good

$path = $this->_getPath();
$Folder = new Folder($path);
@@ -274,7 +274,7 @@ public function log() {
*
* @return void
*/
public function cache() {
public function cache_config() {
$path = $this->_getPath();
$Folder = new Folder($path);
@@ -595,11 +595,11 @@ public function getOptionParser() {
'help' => __d('cake_console', 'Update fixtures to use new index/constraint features. This is necessary before running tests.'),
'parser' => ['options' => compact('plugin', 'dryRun'), 'arguments' => compact('path')],
])
->addSubcommand('cache', [
->addSubcommand('cache_config', [
'help' => __d('cake_console', "Replace Cache::config() with Configure."),
'parser' => ['options' => compact('plugin', 'dryRun'), 'arguments' => compact('path')]
])
->addSubcommand('log', [
->addSubcommand('log_config', [
'help' => __d('cake_console', "Replace CakeLog::config() with Configure."),
'parser' => ['options' => compact('plugin', 'dryRun'), 'arguments' => compact('path')]
]);

0 comments on commit d2ad9c5

Please sign in to comment.
You can’t perform that action at this time.