Skip to content
This repository
Browse code

Correctly passing ellipsis options to all internal method calls insie

PaginatorHelper::numbers(), under some combinations of modulus/limit
it would not get passed even though there are pages in between to show
  • Loading branch information...
commit db247558b07113efa62c7e78ae7e654bc4572735 1 parent 39715bc
José Lorenzo Rodríguez authored July 10, 2012

Showing 1 changed file with 2 additions and 2 deletions. Show diff stats Hide diff stats

  1. 4  lib/Cake/View/Helper/PaginatorHelper.php
4  lib/Cake/View/Helper/PaginatorHelper.php
@@ -701,7 +701,7 @@ public function numbers($options = array()) {
701 701
 				if ($offset < $start - 1) {
702 702
 					$out .= $this->first($offset, compact('tag', 'separator', 'ellipsis', 'class'));
703 703
 				} else {
704  
-					$out .= $this->first($offset, compact('tag', 'separator', 'class') + array('after' => $separator));
  704
+					$out .= $this->first($offset, compact('tag', 'separator', 'class', 'ellipsis') + array('after' => $separator));
705 705
 				}
706 706
 			}
707 707
 
@@ -735,7 +735,7 @@ public function numbers($options = array()) {
735 735
 				if ($offset <= $last && $params['pageCount'] - $end > $offset) {
736 736
 					$out .= $this->last($offset, compact('tag', 'separator', 'ellipsis', 'class'));
737 737
 				} else {
738  
-					$out .= $this->last($offset, compact('tag', 'separator', 'class') + array('before' => $separator));
  738
+					$out .= $this->last($offset, compact('tag', 'separator', 'class', 'ellipsis') + array('before' => $separator));
739 739
 				}
740 740
 			}
741 741
 

0 notes on commit db24755

Please sign in to comment.
Something went wrong with that request. Please try again.