Permalink
Browse files

Removing use of Set::filter(). Coupling the test suite to Set is not …

…a good idea.
  • Loading branch information...
1 parent 1d63d52 commit faafe5a0dce20fc2a2391b058536632789855c30 @markstory markstory committed Jan 6, 2010
Showing with 5 additions and 4 deletions.
  1. +5 −4 cake/tests/lib/reporter/cake_html_reporter.php
@@ -32,6 +32,7 @@ class CakeHtmlReporter extends SimpleReporter {
* Character set for the output of test reporting.
*
* @var string
+ * @access protected
*/
var $_character_set;
/**
@@ -153,7 +154,7 @@ function paintFail($message) {
echo "<li class='fail'>\n";
echo "<span>Failed</span>";
echo "<div class='msg'>" . $this->_htmlEntities($message) . "</div>\n";
- $breadcrumb = Set::filter($this->getTestList());
+ $breadcrumb = $this->getTestList();
array_shift($breadcrumb);
echo "<div>" . implode(" -&gt; ", $breadcrumb) . "</div>\n";
echo "</li>\n";
@@ -173,7 +174,7 @@ function paintPass($message) {
if ($this->_show_passes) {
echo "<li class='pass'>\n";
echo "<span>Passed</span> ";
- $breadcrumb = Set::filter($this->getTestList());
+ $breadcrumb = $this->getTestList();
array_shift($breadcrumb);
echo implode(" -&gt; ", $breadcrumb);
echo "<br />" . $this->_htmlEntities($message) . "\n";
@@ -192,7 +193,7 @@ function paintError($message) {
echo "<li class='error'>\n";
echo "<span>Error</span>";
echo "<div class='msg'>" . $this->_htmlEntities($message) . "</div>\n";
- $breadcrumb = Set::filter($this->getTestList());
+ $breadcrumb = $this->getTestList();
array_shift($breadcrumb);
echo "<div>" . implode(" -&gt; ", $breadcrumb) . "</div>\n";
echo "</li>\n";
@@ -213,7 +214,7 @@ function paintException($exception) {
'] in ['. $exception->getFile() .
' line ' . $exception->getLine() . ']';
echo "<div class='msg'>" . $this->_htmlEntities($message) . "</div>\n";
- $breadcrumb = Set::filter($this->getTestList());
+ $breadcrumb = $this->getTestList();
array_shift($breadcrumb);
echo "<div>" . implode(" -&gt; ", $breadcrumb) . "</div>\n";
echo "</li>\n";

0 comments on commit faafe5a

Please sign in to comment.