Because count queries did not have joins created for the translated fields pagination would generate invalid queries. Checking the conditions for translated fields and adding in the correct joins solves that. Extract what would have been duplicated code into methods. Add a few protected properties to keep method signatures sane. The code could be even simpler if the existing find(count) join was removed. Fixes #2349
- Fix condition checking. Phing was barfing on the old 'code' - Packages would always be made for the previous release. Fix that. - Check return codes so we don't blunder ahead when things go wrong. - Put in invalid data so accidents don't happen.
…lemnet this function
…code with class definitions is not good
…s also reduces the memory usage
…od on it