Permalink
Commits on Jan 9, 2013
  1. Merge branch 'bbcrew-master'

    From pull/1062 reset data arrays when expanding to solve
    infinite recursion issues in PHP5.2
    
    Fixes #3080
    markstory committed Jan 9, 2013
Commits on Jan 8, 2013
  1. Closes ticket #3080 in CakePHP Lighthouse (http://cakephp.lighthousea…

    …pp.com/projects/42648/tickets/3080-hashflatten-endless-loop-on-single-0-int-keys).
    
    Hash::flatten has a bug which causes an endless loop when try to flatten an integer key.
    Probably the $data array pointer won't reset itself when doing:
    
    $data = $element
    
    and
    
    list($data, $path) = array_pop($stack)
    
    The solution is to reset the pointer after the assignments.
    marcotisi committed Jan 8, 2013
  2. Fix radio() and boolean values.

    Boolean values should be cast to integer equivalents, which allows
    for correct handling of boolean columns and their string equivalents
    used in form options.
    
    Fixes #3512
    markstory committed Jan 8, 2013
  3. Remove duplicated assertions.

    These assertions are effectively duplicated in the next test method.
    markstory committed Jan 8, 2013
Commits on Jan 5, 2013
Commits on Jan 4, 2013
  1. Consistently inflect theme names.

    Themes should be consistently converted into CamelCase, this
    makes the camelization consitent with the treatment in App::themePath().
    
    Fixes #3508
    markstory committed Jan 4, 2013
Commits on Jan 3, 2013
  1. Fix double encoding in JsHelper request methods.

    The urls were being HTML & URL encoded, this causes issues with URL's
    containing query string parameters.  Remove HTML entities as they aren't
    required in the Javascript context.
    
    Fixes #3495
    markstory committed Jan 3, 2013
  2. Merge pull request #1055 from and-ers/master

    Optimize and switch array_push() for [] =
    markstory committed Jan 3, 2013
Commits on Jan 2, 2013
  1. Replaced simple and therefore pointless array_push function reference…

    …s with the ordinary way of adding an array element. This will increase the performance and the code looks much cleaner this way IMHO
    and-ers committed Jan 2, 2013
Commits on Dec 29, 2012
  1. Blackhole requests when the action is the blackhole callback.

    When a user requests the blackhole callback as an action we should
    blackhole that request. The blackhole callback should not be URL
    accessible.
    
    Fixes #3496
    markstory committed Dec 29, 2012
Commits on Dec 28, 2012
  1. Handle MissingViewExceptions better.

    When Router::parseExtensions() is enabled for a file extension
    that does not map to a view an infinite loop of attempting to render
    View/$ext/error500.ctp will be entered. When catching
    a MissingViewException check if we were trying to render an
    error500. If we were, revert to safe rendering as we might enter a loop.
    markstory committed Dec 28, 2012
Commits on Dec 27, 2012
  1. Fix SQL errors in TreeBehavior.

    SQL errors were caused by escapeField() usage in TreeBehavior. Quoted
    fields were not correctly unquoted.
    
    Fixes #3491
    markstory committed Dec 27, 2012
Commits on Dec 22, 2012
  1. Merge pull request #982 from shama/editorconfig

    Add .editorconfig file
    lorenzo committed Dec 22, 2012
Commits on Dec 21, 2012
  1. Merge pull request #1038 from ravage84/patch-1

    Fix manual link
    ADmad committed Dec 21, 2012
  2. Update lib/Cake/Model/Model.php

    Corrected an unlogic link from Model:find to an appropriate page in the docs
    ravage84 committed Dec 21, 2012
Commits on Dec 20, 2012
  1. Fix foreach error when useTable = false.

    When calling model->create() with useTable = false, an error should not
    be triggered.
    
    Fixes #3480
    markstory committed Dec 20, 2012
Commits on Dec 19, 2012
  1. Fix docblock

    ADmad committed Dec 19, 2012
  2. Fix docblock

    ADmad committed Dec 19, 2012
Commits on Dec 18, 2012
  1. Change line length in emails.

    Use LINE_LENGTH_MUST instead of LINE_LENGTH_SHOULD. This
    fixes a number of text wrapping issues caused by the narrower wrap
    length.
    
    Fixes #3151
    Fixes #3473
    markstory committed Dec 18, 2012
Commits on Dec 17, 2012
Commits on Dec 16, 2012
  1. Added deprecated tag

    ADmad committed Dec 16, 2012
  2. Don't return true when there is nothing to save.

    Model::save() should not return true when no work has been done.
    
    Fixes #3469
    markstory committed Dec 16, 2012
Commits on Dec 15, 2012
  1. Add codestyle and reports-ci targets to phing.

    This should make it easier to run and test the various code
    reports + stylechecking.
    markstory committed Dec 15, 2012
Commits on Dec 13, 2012
  1. Merge pull request #1022 from ceeram/2.2-3452

    Do not pass 5th argument to mail() when in safe mode
    
    Fixes #3452
    markstory committed Dec 13, 2012
  2. do not pass 5th argument to mail() when in safe mode, even with a fal…

    …sy value mail() will return false, fixes #3452
    ceeram committed Dec 13, 2012
  3. Merge pull request #997 from rhelms/2.2.5-text-index-in-fixture

    Cater for length part of TEXT field in indexes for MySQL'
    
    Fixes #3428
    markstory committed Dec 13, 2012
Commits on Dec 12, 2012
  1. Cater for length part of TEXT field in indexes for MySQL

    Cater for length on TEXT column in index for _alterIndexes
    
    Handle nested arrays in schemas
    
    Used when writing indexes containg TEXT field for MySQL
    
    Change comment style from code review
    
    Remove stray space
    
    Only generate length part of TEXT index column field when necessary
    
    Override buildIndex() in Mysql instead of name()
    Revert DboSource::buildIndex to previous state
    Update Mysql::_alterIndexes for code reuse
    Update MysqlTest to handle quoted index names.
    
    Make code clearer, as per code review
    
    Adjust function comments, as per code review
    rhelms committed Dec 3, 2012
Commits on Dec 11, 2012
  1. Merge branch 'zero-option'

    Related to pull request #1013
    markstory committed Dec 11, 2012