Skip to content
This repository

Apr 14, 2014

  1. Mark Story

    Merge pull request #3319 from dogmatic69/patch-1

    Fix closing non resource
    authored
  2. Carl Sutton

    Fix closing non resource

    I get a load of these errors when running tests in the shell, this check stops the errors from happening
    
    Warning: 2 :: fclose() expects parameter 1 to be resource, integer given on line 298 of CORE\Cake\Console\ConsoleOutput.php
    Trace:
    fclose - [internal], line ??
    ConsoleOutput::__destruct() - CORE\Cake\Console\ConsoleOutput.php, line 298
    ToolbarComponent::_saveState() - APP\Plugin\DebugKit\Controller\Component\ToolbarComponent.php, line 307
    ToolbarComponent::beforeRedirect() - APP\Plugin\DebugKit\Controller\Component\ToolbarComponent.php, line 307
    ObjectCollection::trigger() - CORE\Cake\Utility\ObjectCollection.php, line 132
    call_user_func - [internal], line ??
    CakeEventManager::dispatch() - CORE\Cake\Event\CakeEventManager.php, line 247
    Controller::redirect() - CORE\Cake\Controller\Controller.php, line 765
    AuthComponent::_unauthenticated() - CORE\Cake\Controller\Component\AuthComponent.php, line 364
    AuthComponent::startup() - CORE\Cake\Controller\Component\AuthComponent.php, line 304
    ObjectCollection::trigger() - CORE\Cake\Utility\ObjectCollection.php, line 132
    call_user_func - [internal], line ??
    CakeEventManager::dispatch() - CORE\Cake\Event\CakeEventManager.php, line 247
    Controller::startupProcess() - CORE\Cake\Controller\Controller.php, line 675
    Dispatcher::_invoke() - CORE\Cake\Routing\Dispatcher.php, line 182
    Dispatcher::dispatch() - CORE\Cake\Routing\Dispatcher.php, line 160
    authored
  3. José Lorenzo Rodríguez

    Merge pull request #3316 from bcrowe/hotfix-controller-template

    Add newline after actions in controller template
    authored
  4. Bryan Crowe

    Fix failing NoActions comparison test

    authored
  5. Bryan Crowe

    Add newline after actions in controller template

    authored

Apr 13, 2014

  1. Mark Story

    Correct types for Validation::range().

    Refs #3304
    authored

Apr 11, 2014

  1. Mark Story

    Merge pull request #3301 from ubermaniac/Sqlserver-trim

    Trim $sql before checking for SELECT
    authored
  2. Trim $sql before checking for SELECT

    authored
  3. Mark Story

    Merge pull request #3297 from young-steveo/AclComponent-documentation…

    …-fix
    
    Updated AclComponent documentation
    authored
  4. Stephen Young

    Updated documentation

    * Removed references to nonexistent `AclBase` class
    * Added references to `AclInterface` requirements
    authored
  5. Mark Story

    Merge branch 'hash-fix' from glaforge/patch-1 into master.

    Closes #3288
    authored
  6. Mark Story

    Add tests for #3288 and remove nested ternaries.

    Nested ternaries are complicated to maintain and hard to read. Break
    down the nested ternary into two conditionals.
    authored

Apr 10, 2014

  1. Guillaume Lafarge

    Fix Hash type casting

    When using comparison with a boolean, as the filter is a string, we have to convert the data boolean to "boolean string" to avoid type-casting troubles.
    
    ## Example
    ```php
    $users = [
        [
            'id' => 2,
            'username' => 'johndoe',
            'active' => true
        ],
        [   'id' => 5,
            'username' => 'kevin',
            'active' => true
        ],
        [
            'id' => 9,
            'username' => 'samantha',
            'active' => false
        ],
    ];
    $unactiveUsers = Hash::extract($users, '{n}[active=false]');
    print_r($unactiveUsers);
    ```
    
    This example returns the two unwanted active users because `"false"` is `true` but not `false` :)
    
    I think this pull request will fix this issue by converting true/false boolean to string (to match with our filter).
    authored

Apr 09, 2014

  1. Mark Story

    Merge pull request #3210 from ubermaniac/Sqlserver-schema-prefix

    Sqlserver schema prefix #3208
    authored

Apr 06, 2014

  1. José Lorenzo Rodríguez

    Merge pull request #3247 from cakephp/master-docblocks

    Correct doc blocks
    authored
  2. Mark

    Correct doc blocks

    authored
  3. José Lorenzo Rodríguez

    Revert "Merge pull request #3002 from moberemk/patch-2"

    This reverts commit 8e3d6cf, reversing
    changes made to 9280088.
    authored
  4. José Lorenzo Rodríguez

    Merge pull request #3002 from moberemk/patch-2

    Allow chaining in the addCrumb method
    authored

Apr 05, 2014

  1. Mark Story

    Update version number to 2.4.7

    authored
  2. Mark Story

    Add file missed in last commit.

    authored
  3. Mark Story

    Fix email rendering when using 2 different plugins.

    When an email template and layout are in different plugins the incorrect
    plugin would be used for the layout.
    
    Fixes #3062
    authored
  4. Mark Story

    Only count `_id` if it is the last 3 characters in the field name.

    This prevents issues when baking models for tables containing `_id`.
    
    Fixes #3230
    authored

Apr 04, 2014

  1. Mark Story

    Merge pull request #3224 from dereuromark/master-deprecations

    correct deprecation notices
    authored
  2. Mark

    generalize sentence

    authored
  3. Mark

    correct deprecation notices

    authored

Apr 02, 2014

  1. ceeram

    Change argument type to mixed in docblock, as debug() and pr() accept…

    … not just a single type
    authored
  2. Sqlserver Datasource how properly appends the schemaName prefix in th…

    …e describe() method
    authored
  3. Base model class no longer changes an already defined schemaName value

    authored
  4. José Lorenzo Rodríguez

    Merge pull request #3197 from dereuromark/master-cs

    cs
    authored
  5. Mark

    correct missed cs errors

    authored
  6. Mark

    fix indentation

    authored
  7. Mark

    more cs

    authored
  8. Mark

    more missing doc block tags added

    authored
  9. Mark

    cs

    authored

Apr 01, 2014

  1. ADmad

    Merge pull request #3193 from beporter/feature/phpunit-required-version

    Adds phpunit required version to TestShell "not found" error message.
    authored
Something went wrong with that request. Please try again.