Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memcached.use_sasl is no longer a thing in memcached extension version 3 #11027

Closed
dzuelke opened this Issue Aug 10, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@dzuelke
Copy link

dzuelke commented Aug 10, 2017

This is a (multiple allowed):

  • bug

  • enhancement

  • feature-discussion (RFC)

  • CakePHP Version: master

  • Platform and Target: PHP 7.1.8 with memcached extension 3.0.3

What you did

Called MemcachedEngine::init() on PHP with memcached extension, built with SASL support.

What happened

An exception got thrown, because the memcached.use_sasl INI setting no longer exists in version 3 of the extension (released in February 2017). See https://pecl.php.net/package-info.php?package=memcached&version=3.0.0

2017-08-09 18:48:04 Error: [InvalidArgumentException] Memcached extension is not build with SASL support
Request URL: …
Stack Trace:
#0 vendor/cakephp/cakephp/src/Cache/CacheRegistry.php(90): Cake\Cache\Engine\MemcachedEngine->init(Array)
…

What you expected to happen

Exception should not be thrown for memcached extension 3.0.0 and later.

@markstory markstory added this to the 3.4.13 milestone Aug 10, 2017

@markstory markstory self-assigned this Aug 10, 2017

@markstory

This comment has been minimized.

Copy link
Member

markstory commented Aug 10, 2017

I'll take a look.

markstory added a commit that referenced this issue Aug 11, 2017

Remove ini flag for memcached.sasl
This ini flag doesn't exist in newer versions of memcached. Instead we
should use the existence of the method to see if memcached was compiled
with sasl support.

Refs #11027
@markstory

This comment has been minimized.

Copy link
Member

markstory commented Aug 11, 2017

Pull request up now.

@markstory markstory closed this Aug 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.