Rename Query::_applyFormatters Query::_decorateResults #2413

Closed
AD7six opened this Issue Dec 2, 2013 · 1 comment

Comments

Projects
None yet
2 participants
Member

AD7six commented Dec 2, 2013

The names of these two methods should be changed to avoid confusion e.g.

Query::_applyFormatters -> Query::_decorateResults
Query::_decorateResults -> Query::_decorateStatement

@ghost ghost assigned AD7six Dec 2, 2013

Owner

markstory commented Dec 2, 2013

Sounds reasonable to me.

AD7six added a commit to AD7six/cakephp that referenced this issue Dec 3, 2013

rename decorate results and decorate statement
in this way, decorateResults calls ResultSetDecorator, which is less
likely to be confusing, and _decorateStatement decorates a statement

closes #2413

@AD7six AD7six closed this Dec 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment