3.1 Session => ['defaults' => 'cake'] should try to auto-create tmp/sessions if not existing

[ionas]

When switching from A:

    'Session' => [
        'defaults' => 'php',
    ],

to B:

    'Session' => [
        'defaults' => 'cake',
    ],

... because of the existence of an application cluster, the session path in tmp was not found and resulted in an error:

Warning (2): session_start(): open(/var/www/app/tmp/sessions/sess_4tkdpateu38p9l9n7iolj4qta1, O_RDWR) failed: No such file or directory (2) [CORE/src/Network/Session.php, line 324]

Should switching from A to B try to auto-create tmp/sessions path if not existing?

[markstory]

I am not so sure we want to try and create directories that don't exist. Unless we did some special casing, we'd be trying to ensure that session.save_path existed if it wasn't defined and we could run into issues around filesystem permissions or open_basedir limitations.

[markstory]

I am not so sure we want to try and create directories that don't exist. Unless we did some special casing, we'd be trying to ensure that session.save_path existed if it wasn't defined and we could run into issues around filesystem permissions or open_basedir limitations.

[htstudios]

Within ROOT/tmp/ it should be okay?
Don't we do the same for cache, models, persistent etc?

[htstudios]

Within ROOT/tmp/ it should be okay?
Don't we do the same for cache, models, persistent etc?

[ADmad]

tmp/sessions is already created at install time along with other tmp directories. We should definitely not try to create directories at runtime.

[ADmad]

tmp/sessions is already created at install time along with other tmp directories. We should definitely not try to create directories at runtime.

[ionas]

The gap that surprises is, following directories get setup on install time:
ROOT/logs
ROOT/tmp
ROOT/tmp/cache
ROOT/tmp/cache/models
ROOT/tmp/cache/persistent
ROOT/tmp/cache/views
ROOT/tmp/sessions

"We should definitely not try to create directories at runtime" (@ADmad)

Following directories are created at runtime.
Thus they will be re-created (tested just now) if they got deleted:
ROOT/logs
ROOT/tmp
ROOT/tmp/cache
ROOT/tmp/cache/models
ROOT/tmp/cache/persistent
ROOT/tmp/cache/views
ROOT/tmp/sessions

Did not test for ROOT/tmp/tests, e.g. if it gets recreated on demand.

p.s.: I'd have preferred to discuss this in short on IRC.

[ionas]

The gap that surprises is, following directories get setup on install time:
ROOT/logs
ROOT/tmp
ROOT/tmp/cache
ROOT/tmp/cache/models
ROOT/tmp/cache/persistent
ROOT/tmp/cache/views
ROOT/tmp/sessions

"We should definitely not try to create directories at runtime" (@ADmad)

Following directories are created at runtime.
Thus they will be re-created (tested just now) if they got deleted:
ROOT/logs
ROOT/tmp
ROOT/tmp/cache
ROOT/tmp/cache/models
ROOT/tmp/cache/persistent
ROOT/tmp/cache/views
ROOT/tmp/sessions

Did not test for ROOT/tmp/tests, e.g. if it gets recreated on demand.

p.s.: I'd have preferred to discuss this in short on IRC.

[dereuromark]

@ionas Folders are only created in debug mode, not production.
Also, tmp, logs, cache and tmp/sessions for CakePHP itself is fine , but another outside is not OK and should be done automatically.

See https://github.com/cakephp/cakephp/blob/master/src/Log/Engine/FileLog.php#L90-L95
The same for debug mode only should be applied to all the tmp stuff inside the APP.

[dereuromark]

@ionas Folders are only created in debug mode, not production.
Also, tmp, logs, cache and tmp/sessions for CakePHP itself is fine , but another outside is not OK and should be done automatically.

See https://github.com/cakephp/cakephp/blob/master/src/Log/Engine/FileLog.php#L90-L95
The same for debug mode only should be applied to all the tmp stuff inside the APP.

[ionas]

In case there is a will for consistency let me know and I will try to fix it ASAP.

[ionas]

In case there is a will for consistency let me know and I will try to fix it ASAP.

[dereuromark]

Please make a PR. I think that will make the discussion easier as it will be more code hands-on and less theoretical.

[dereuromark]

Please make a PR. I think that will make the discussion easier as it will be more code hands-on and less theoretical.