New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to define a custom routeClass for builder redirects #10145

Merged
merged 2 commits into from Sep 21, 2017

Conversation

Projects
None yet
7 participants
@patrickconroy
Contributor

patrickconroy commented Jan 31, 2017

Refs #10144

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 31, 2017

Codecov Report

Merging #10145 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #10145      +/-   ##
============================================
+ Coverage     93.14%   93.15%   +<.01%     
- Complexity    12982    12983       +1     
============================================
  Files           437      437              
  Lines         33630    33631       +1     
============================================
+ Hits          31324    31328       +4     
+ Misses         2306     2303       -3
Impacted Files Coverage Δ Complexity Δ
src/Routing/RouteBuilder.php 99.58% <100%> (ø) 87 <0> (+1) ⬆️
src/Cache/CacheRegistry.php 100% <0%> (+4%) 11% <0%> (ø) ⬇️
src/Cache/CacheEngine.php 93.61% <0%> (+4.25%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66c8fc3...dbdaae8. Read the comment docs.

codecov-io commented Jan 31, 2017

Codecov Report

Merging #10145 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #10145      +/-   ##
============================================
+ Coverage     93.14%   93.15%   +<.01%     
- Complexity    12982    12983       +1     
============================================
  Files           437      437              
  Lines         33630    33631       +1     
============================================
+ Hits          31324    31328       +4     
+ Misses         2306     2303       -3
Impacted Files Coverage Δ Complexity Δ
src/Routing/RouteBuilder.php 99.58% <100%> (ø) 87 <0> (+1) ⬆️
src/Cache/CacheRegistry.php 100% <0%> (+4%) 11% <0%> (ø) ⬇️
src/Cache/CacheEngine.php 93.61% <0%> (+4.25%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66c8fc3...dbdaae8. Read the comment docs.

@dereuromark dereuromark added this to the 3.3.14 milestone Jan 31, 2017

@dereuromark

This comment has been minimized.

Show comment
Hide comment
@dereuromark
Member

dereuromark commented Jan 31, 2017

👍

@markstory

A test would be 🌈

@markstory markstory modified the milestones: 3.3.14, 3.3.15, 3.4.1 Feb 6, 2017

@markstory markstory modified the milestones: 3.4.1, 3.4.2, 3.4.3 Feb 18, 2017

@markstory markstory modified the milestones: 3.4.3, 3.4.4 Mar 10, 2017

@markstory markstory modified the milestones: 3.4.4, 3.4.5 Mar 29, 2017

@markstory markstory removed this from the 3.4.5 milestone Apr 10, 2017

@markstory markstory modified the milestones: 3.4.12, 3.4.13 Aug 2, 2017

@markstory markstory modified the milestones: 3.4.13, 3.5.0, 3.5.1 Aug 17, 2017

@markstory markstory modified the milestones: 3.5.1, 3.5.2 Aug 29, 2017

@markstory markstory modified the milestones: 3.5.2, 3.5.3 Sep 12, 2017

@dereuromark

This comment has been minimized.

Show comment
Hide comment
@dereuromark

dereuromark Sep 20, 2017

Member

@patrickconroy Are you still interested in finishing this up?

Member

dereuromark commented Sep 20, 2017

@patrickconroy Are you still interested in finishing this up?

@jeremyharris

This comment has been minimized.

Show comment
Hide comment
@jeremyharris

jeremyharris Sep 20, 2017

Member

Feel free to ping me if you need help with the tests.

Member

jeremyharris commented Sep 20, 2017

Feel free to ping me if you need help with the tests.

@jeremyharris jeremyharris self-assigned this Sep 21, 2017

Patrick Conroy and others added some commits Jan 31, 2017

@saeideng

This comment has been minimized.

Show comment
Hide comment
@saeideng

saeideng Sep 21, 2017

Member

I will add a test to this tonight unless someone added test before me
//edit
I see @jeremyharris commit after posting this
thanks

Member

saeideng commented Sep 21, 2017

I will add a test to this tonight unless someone added test before me
//edit
I see @jeremyharris commit after posting this
thanks

@dereuromark

This comment has been minimized.

Show comment
Hide comment
@dereuromark

dereuromark Sep 21, 2017

Member

Looks like a test is now already in place.
👍 All green it seems.

Member

dereuromark commented Sep 21, 2017

Looks like a test is now already in place.
👍 All green it seems.

@lorenzo

This comment has been minimized.

Show comment
Hide comment
@lorenzo

lorenzo Sep 21, 2017

Member

Thanks!

Member

lorenzo commented Sep 21, 2017

Thanks!

@lorenzo lorenzo merged commit 46f7e4a into cakephp:master Sep 21, 2017

5 checks passed

codecov/patch 100% of diff hit (target 93.14%)
Details
codecov/project 93.15% (+<.01%) compared to 66c8fc3
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment