Added autoP functionality #1023

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

TeckniX commented Dec 14, 2012

Adds autoP support for common text spacing when formatting dynamic content.
Similar string file will be updated in the utility file

@TeckniX TeckniX Added autoP functionality
Adds autoP support for common text spacing when formatting dynamic content.
Similar string file will be updated
28f7dce
Member

dereuromark commented Dec 14, 2012

You don't have to make separate PRs for each class.
It would be wise to submit your changes to both String and TextHelper at the same time with the same PR. And some test cases would also be needed.
But besides that, the master branch is only for bugfixes. New features must go into 2.4 (as soon as it is possible) or 3.0

@ other coredevs
we should add the information about the branch strategy to the readme. this might help to clear this up in the future.

dereuromark reopened this Dec 14, 2012

Member

dereuromark commented Dec 14, 2012

Thinking about it, the String class should not have to deal with HTML markup. therefore you should only have to modify the TextHelper here. The TextHelper is the one in the View scope where HTML is actually used.

Also, naming it autoParagraph might be a more suitable name than just autoP.

Contributor

TeckniX commented Dec 14, 2012

I'll make the proper edits and will resubmit - Thanks

TeckniX closed this Dec 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment