New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extract() from ServerRequestFactory::getBase() #10768

Merged
merged 1 commit into from Jun 14, 2017

Conversation

Projects
None yet
5 participants
@slywalker
Contributor

slywalker commented Jun 13, 2017

By using extract(), I propose a modification because it causes poor readability as well as side effects (overwriting $uri, $server).

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 13, 2017

Codecov Report

Merging #10768 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #10768      +/-   ##
============================================
- Coverage      94.9%    94.9%   -0.01%     
  Complexity    12118    12118              
============================================
  Files           422      422              
  Lines         30104    30103       -1     
============================================
- Hits          28570    28569       -1     
  Misses         1534     1534
Impacted Files Coverage Δ Complexity Δ
src/Http/ServerRequestFactory.php 100% <100%> (ø) 33 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4786b3...e71b1e3. Read the comment docs.

codecov-io commented Jun 13, 2017

Codecov Report

Merging #10768 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #10768      +/-   ##
============================================
- Coverage      94.9%    94.9%   -0.01%     
  Complexity    12118    12118              
============================================
  Files           422      422              
  Lines         30104    30103       -1     
============================================
- Hits          28570    28569       -1     
  Misses         1534     1534
Impacted Files Coverage Δ Complexity Δ
src/Http/ServerRequestFactory.php 100% <100%> (ø) 33 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4786b3...e71b1e3. Read the comment docs.

@dereuromark dereuromark added this to the 3.4.8 milestone Jun 13, 2017

@ADmad

ADmad approved these changes Jun 13, 2017

@markstory markstory merged commit 41e9cf1 into cakephp:master Jun 14, 2017

5 checks passed

codecov/patch 100% of diff hit (target 94.9%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +5.09% compared to b4786b3
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
@markstory

This comment has been minimized.

Show comment
Hide comment
@markstory

markstory Jun 14, 2017

Member

Thanks @slywalker 👏

Member

markstory commented Jun 14, 2017

Thanks @slywalker 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment