Added configurable default value to Configure::read()

[h-moriya]

default value to Configure::read()

Configure::read('key','none'); = Configure::read('key') ?? 'none';

It works the same as env ()

[dereuromark]

Sounds reasonable given the other reader methods also have this default argument.

[cleptric]

What use case do you see for this feature? Do you end up missing a config option on a given case?

[dereuromark]

For BC reasons this could however go into 3.5 better
As people could have extended the Configure class and call e.g. MyConfigure::read() which would then throw notices due to the signature change.
Very theoretical, though.

[codecov-io]

Codecov Report

Merging #10890 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #10890      +/-   ##
============================================
- Coverage     94.94%   94.93%   -0.01%     
  Complexity    12137    12137              
============================================
  Files           422      422              
  Lines         30168    30168              
============================================
- Hits          28643    28641       -2     
- Misses         1525     1527       +2

Impacted Files	Coverage Δ	Complexity Δ
src/Core/Configure.php	96.47% <100%> (ø)	39 <2> (ø)	⬇️
src/Cache/Engine/FileEngine.php	85.47% <0%> (-1.12%)	72% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf71a5...585d509. Read the comment docs.

[markstory]

Moved to 3.next

[h-moriya]

@cleptric
I think that use it in this case

https://github.com/CakeDC/ratings/blob/31136942e4dab7563b64ad3c18b96db13aaaabae/Model/Rating.php#L41
https://github.com/multidots/cakephp-rest-api/blob/867bcc5687310cf3424a03de8c11618b0cc45b15/src/Controller/AppController.php#L68
https://github.com/uzyn/cakephp-opauth/blob/2ca4dc8f887a5ea09b2536b7d1630f4db7f123b9/Controller/OpauthAppController.php#L110

[ravage84]

Lovely, that was on my TODO list for so long. Thanks for taking care of.

[ravage84]

You don't need to do that. This is taken careof when it get's released.

[dereuromark]

this is because of branch change. can be disregarded.

[markstory]

Thanks @h-moriya 👏