Skip to content

Added "tel" and "email" input type guessing. #1090

Merged
merged 1 commit into from Jan 27, 2013

2 participants

@ADmad
CakePHP member
ADmad commented Jan 25, 2013

Refs #3557

I am on the fence regarding using "url" type guessing as it does validation for absolute url which might not always be desirable. I believe it's common usage to not require end users to enter absolute urls.

@markstory
CakePHP member

Always requiring an absolute url might be a bad thing. I agree that we probably shouldn't use those input types as a convention.

@ADmad ADmad merged commit 422ceaf into cakephp:2.3 Jan 27, 2013
@ADmad ADmad deleted the ADmad:2.3-formhelper branch Jan 27, 2013
@markstory
CakePHP member

Make sure you remember to update the docs 😄

@ADmad
CakePHP member
ADmad commented Jan 27, 2013

I generally don't forget, thanks for the reminder 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.