add supportsQuoting() #1106

Merged
merged 1 commit into from Feb 2, 2013

Conversation

Projects
None yet
3 participants
Member

ceeram commented Feb 1, 2013

changes required to pass AllDatabase tests when connecting to Mysql with odbc

Owner

lorenzo commented Feb 1, 2013

There should be an abstract supportsQuoting() method in the Driver base class too

Owner

markstory commented Feb 1, 2013

Do we want to try and support odbc?

Owner

lorenzo commented Feb 1, 2013

That is what he is trying to do right now. I think it is worth the try...

On Fri, Feb 1, 2013 at 3:42 PM, Mark Story notifications@github.com wrote:

Do we want to try and support odbc?


Reply to this email directly or view it on GitHubhttps://github.com/cakephp/cakephp/pull/1106#issuecomment-12996805.

Member

ceeram commented Feb 1, 2013

I am not sure if its possible to work with all odbc drivers, but surely worth a try, currently i was able to use the Mysql driver class with odbc dsn to connect to Mysql database and pass AllDatabaseTests with it now. Surely using PDO_ODBC to connect to Mysql db server does not make much sense, but this way was the easiest to test the PDODriver with odbc, as i would like to continue connect to other db with 3.0 as i am now with 2.3. In 2.3 this requires a lot of overriding. I hope to make it easier in 3.0, lets see how far we can get?

Owner

markstory commented Feb 1, 2013

Sure its worth trying :) We may only want to advertise that we connect to known SQL dialects over odbc in the end.

lorenzo added a commit that referenced this pull request Feb 2, 2013

@lorenzo lorenzo merged commit a21461e into cakephp:3.0-database Feb 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment