New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parseDSN not working for SqlLocalDB #11071

Merged
merged 1 commit into from Aug 21, 2017

Conversation

Projects
None yet
3 participants
@chinpei215
Member

chinpei215 commented Aug 21, 2017

When using SqlLocalDB, the host part will be (localdb)\.\DeptSharedLocalDB and the current regular expression doesn't match it.

Also I have fixed the regex for url with fragment, and removed unused code.

@chinpei215 chinpei215 added the Defect label Aug 21, 2017

@chinpei215 chinpei215 added this to the 3.5.1 milestone Aug 21, 2017

Fix parseDSN not working for SqlLocalDB
Also fix the regex for url with fragment.
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 21, 2017

Codecov Report

Merging #11071 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11071      +/-   ##
============================================
+ Coverage     94.85%   94.86%   +<.01%     
+ Complexity    12837    12835       -2     
============================================
  Files           437      437              
  Lines         32729    32724       -5     
============================================
- Hits          31046    31042       -4     
+ Misses         1683     1682       -1
Impacted Files Coverage Δ Complexity Δ
src/Core/StaticConfigTrait.php 98.71% <100%> (+1.12%) 36 <0> (-2) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fffda82...8a91fca. Read the comment docs.

codecov-io commented Aug 21, 2017

Codecov Report

Merging #11071 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11071      +/-   ##
============================================
+ Coverage     94.85%   94.86%   +<.01%     
+ Complexity    12837    12835       -2     
============================================
  Files           437      437              
  Lines         32729    32724       -5     
============================================
- Hits          31046    31042       -4     
+ Misses         1683     1682       -1
Impacted Files Coverage Δ Complexity Δ
src/Core/StaticConfigTrait.php 98.71% <100%> (+1.12%) 36 <0> (-2) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fffda82...8a91fca. Read the comment docs.

@markstory markstory merged commit 1a4a27a into cakephp:master Aug 21, 2017

5 checks passed

codecov/patch 100% of diff hit (target 94.85%)
Details
codecov/project 94.86% (+<.01%) compared to fffda82
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.

@chinpei215 chinpei215 deleted the chinpei215:fix-parse-dsn branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment