New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Form::setErrors(). #11109

Merged
merged 1 commit into from Aug 29, 2017

Conversation

Projects
None yet
3 participants
@ADmad
Member

ADmad commented Aug 27, 2017

Closes #10971

@ADmad ADmad added this to the 3.5.1 milestone Aug 27, 2017

@ADmad ADmad added the Enhancement label Aug 27, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 27, 2017

Codecov Report

Merging #11109 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11109      +/-   ##
============================================
+ Coverage     94.88%   94.88%   +<.01%     
- Complexity    12847    12848       +1     
============================================
  Files           437      437              
  Lines         32761    32764       +3     
============================================
+ Hits          31086    31089       +3     
  Misses         1675     1675
Impacted Files Coverage Δ Complexity Δ
src/Form/Form.php 94.44% <100%> (+0.5%) 17 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c98803...37c1f1b. Read the comment docs.

codecov-io commented Aug 27, 2017

Codecov Report

Merging #11109 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11109      +/-   ##
============================================
+ Coverage     94.88%   94.88%   +<.01%     
- Complexity    12847    12848       +1     
============================================
  Files           437      437              
  Lines         32761    32764       +3     
============================================
+ Hits          31086    31089       +3     
  Misses         1675     1675
Impacted Files Coverage Δ Complexity Δ
src/Form/Form.php 94.44% <100%> (+0.5%) 17 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c98803...37c1f1b. Read the comment docs.

@markstory

Looks good to me.

@markstory markstory merged commit ded8f3c into master Aug 29, 2017

6 checks passed

codecov/patch 100% of diff hit (target 94.88%)
Details
codecov/project 94.88% (+<.01%) compared to 7c98803
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
stickler-ci No lint errors found.

@markstory markstory deleted the form-set-errors branch Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment