Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added a note about plugin assets not working without url rewrite #1113

Closed
wants to merge 10 commits into
from

Conversation

Projects
None yet
3 participants
Member

ravage84 commented Feb 2, 2013

http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit

--> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin."

--> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience."

see also:
http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem

http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8

ravage84 added some commits Feb 2, 2013

@ravage84 ravage84 Fixed typo 85ba689
@ravage84 ravage84 Fixed typo f5038de
@ravage84 ravage84 Added a note about plugin assets not working witout url rewrite
http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit

--> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin."

--> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience."

see also:
http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem

http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8
bf91266
@ravage84 ravage84 Added a note about plugin assets not working without url rewrite
http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit

--> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin."

--> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience."

see also:
http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem

http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8
d049a3f
@ravage84 ravage84 Fixed introduced typo... 3c10322

@ADmad ADmad commented on the diff Feb 2, 2013

app/Config/core.php
@@ -92,7 +92,9 @@
* /app/.htaccess
* /app/webroot/.htaccess
*
- * And uncomment the App.baseUrl below:
+ * And uncomment the App.baseUrl below. But keep in mind
+ * that plugin assets such as images, CSS and Javascript files
+ * will not work without url rewriting!
@ADmad

ADmad Feb 2, 2013

Member

Should probably also add the solution. i.e. you should either copy or symlink the plugin assets into webroot

@ravage84

ravage84 Feb 2, 2013

Member

What do you think about this addition?

To work around this issue you should either symlink or copy the plugin assets into you app's webroot directory. This is recommended even when you are using mod_rewrite. Handling static assets through the Dispatcher is incredibly inefficient and included primarily as a development convenience - and thus not recommended for production applications.

@ADmad

ADmad Feb 2, 2013

Member

👍 Please squash your commits after making this change.

@ravage84

ravage84 Feb 3, 2013

Member

Should be squashed now. Fixed also my typos. Thanks

@ADmad

ADmad Feb 3, 2013

Member

No the commits are not squashed. Your pull request now has 8 commits and expected is just 1 😄

@markstory markstory commented on an outdated diff Feb 2, 2013

app/Config/core.php
@@ -92,7 +92,15 @@
* /app/.htaccess
* /app/webroot/.htaccess
*
- * And uncomment the App.baseUrl below:
+ * And uncomment the App.baseUrl below. But keep in mind
+ * that plugin assets such as images, CSS and Javascript files
+ * will not work without url rewriting!
+ * To work around this issue you should either symlink or copy
+ * the plugin assets into you app's webroot directory. This is
+ * ecommended even when you are using mod_rewrite. Handling static
@markstory

markstory Feb 2, 2013

Owner

should be recommended not ecommended.

@markstory markstory commented on an outdated diff Feb 2, 2013

lib/Cake/Console/Templates/skel/Config/core.php
@@ -92,7 +92,15 @@
* /app/.htaccess
* /app/webroot/.htaccess
*
- * And uncomment the App.baseUrl below:
+ * And uncomment the App.baseUrl below. But keep in mind
+ * that plugin assets such as images, CSS and Javascript files
+ * will not work without url rewriting!
+ * To work around this issue you should either symlink or copy
+ * the plugin assets into you app's webroot directory. This is
+ * ecommended even when you are using mod_rewrite. Handling static
@markstory

markstory Feb 2, 2013

Owner

Same here.

ravage84 added some commits Feb 3, 2013

@ravage84 ravage84 Fixed two newly introduced typos 1d54622
@ravage84 @ravage84 ravage84 + ravage84 Added a note about plugin assets not working without url rewrite
http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit

--> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin."

--> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience."

see also:
http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem

http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8

Fixed typo

Fixed typo

Added a note about plugin assets not working witout url rewrite

http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit

--> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin."

--> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience."

see also:
http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem

http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8

Fixed introduced typo...

Addition to App.baseurl

#1113 (comment)

Addition to App.baseurl

#1113 (comment)

Fixed two newly introduced typos
a5813ed
@ravage84 ravage84 Merge remote-tracking branch 'origin/patch-1' into patch-1 804753f

@markstory markstory added a commit that referenced this pull request Feb 3, 2013

@ravage84 @markstory ravage84 + markstory Added a note about plugin assets not working witout url rewrite
http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit

> Plugin assets do not work without url rewriting, this is in the
documentation for CakePHP itself. I guess it could be repeated for this
and every other plugin.

> I could have sworn it was with the Plugin Assets section, but
apparently its not there. Perhaps its just something I know from
experience.

See also:

* http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem
* http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8

Signed-off-by: mark_story <mark@mark-story.com>

Refs #GH-1113
af8b1e2
Owner

markstory commented Feb 3, 2013

Thanks 👍 Squashed and merged in af8b1e2

@markstory markstory closed this Feb 3, 2013

@ravage84 ravage84 deleted the unknown repository branch Feb 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment