Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Added a note about plugin assets not working without url rewrite #1113

Closed
wants to merge 10 commits into from

3 participants

Marc Würth Mark Story ADmad
Marc Würth

http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit

--> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin."

--> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience."

see also:
http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem

http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8

ravage84 added some commits
Marc Würth ravage84 Fixed typo 85ba689
Marc Würth ravage84 Fixed typo f5038de
Marc Würth ravage84 Added a note about plugin assets not working witout url rewrite
http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit

--> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin."

--> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience."

see also:
http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem

http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8
bf91266
Marc Würth ravage84 Added a note about plugin assets not working without url rewrite
http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit

--> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin."

--> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience."

see also:
http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem

http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8
d049a3f
Marc Würth ravage84 Fixed introduced typo... 3c10322
ADmad ADmad commented on the diff
app/Config/core.php
@@ -92,7 +92,9 @@
* /app/.htaccess
* /app/webroot/.htaccess
*
- * And uncomment the App.baseUrl below:
+ * And uncomment the App.baseUrl below. But keep in mind
+ * that plugin assets such as images, CSS and Javascript files
+ * will not work without url rewriting!
ADmad Collaborator
ADmad added a note

Should probably also add the solution. i.e. you should either copy or symlink the plugin assets into webroot

Marc Würth
ravage84 added a note

What do you think about this addition?

To work around this issue you should either symlink or copy the plugin assets into you app's webroot directory. This is recommended even when you are using mod_rewrite. Handling static assets through the Dispatcher is incredibly inefficient and included primarily as a development convenience - and thus not recommended for production applications.

ADmad Collaborator
ADmad added a note

:+1: Please squash your commits after making this change.

Marc Würth
ravage84 added a note

Should be squashed now. Fixed also my typos. Thanks

ADmad Collaborator
ADmad added a note

No the commits are not squashed. Your pull request now has 8 commits and expected is just 1 :smile:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
app/Config/core.php
@@ -92,7 +92,15 @@
* /app/.htaccess
* /app/webroot/.htaccess
*
- * And uncomment the App.baseUrl below:
+ * And uncomment the App.baseUrl below. But keep in mind
+ * that plugin assets such as images, CSS and Javascript files
+ * will not work without url rewriting!
+ * To work around this issue you should either symlink or copy
+ * the plugin assets into you app's webroot directory. This is
+ * ecommended even when you are using mod_rewrite. Handling static
Mark Story Owner

should be recommended not ecommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
lib/Cake/Console/Templates/skel/Config/core.php
@@ -92,7 +92,15 @@
* /app/.htaccess
* /app/webroot/.htaccess
*
- * And uncomment the App.baseUrl below:
+ * And uncomment the App.baseUrl below. But keep in mind
+ * that plugin assets such as images, CSS and Javascript files
+ * will not work without url rewriting!
+ * To work around this issue you should either symlink or copy
+ * the plugin assets into you app's webroot directory. This is
+ * ecommended even when you are using mod_rewrite. Handling static
Mark Story Owner

Same here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
ravage84 added some commits
Marc Würth ravage84 Fixed two newly introduced typos 1d54622
Marc Würth ravage84 Added a note about plugin assets not working without url rewrite
http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit

--> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin."

--> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience."

see also:
http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem

http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8

Fixed typo

Fixed typo

Added a note about plugin assets not working witout url rewrite

http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit

--> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin."

--> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience."

see also:
http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem

http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8

Fixed introduced typo...

Addition to App.baseurl

cakephp/cakephp#1113 (comment)

Addition to App.baseurl

cakephp/cakephp#1113 (comment)

Fixed two newly introduced typos
a5813ed
Marc Würth ravage84 Merge remote-tracking branch 'origin/patch-1' into patch-1 804753f
Mark Story markstory referenced this pull request from a commit
Marc Würth ravage84 Added a note about plugin assets not working witout url rewrite
http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit

> Plugin assets do not work without url rewriting, this is in the
documentation for CakePHP itself. I guess it could be repeated for this
and every other plugin.

> I could have sworn it was with the Plugin Assets section, but
apparently its not there. Perhaps its just something I know from
experience.

See also:

* http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem
* http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8

Signed-off-by: mark_story <mark@mark-story.com>

Refs #GH-1113
af8b1e2
Mark Story
Owner

Thanks :+1: Squashed and merged in af8b1e2

Mark Story markstory closed this
Marc Würth ravage84 deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 2, 2013
  1. Marc Würth

    Fixed typo

    ravage84 authored
  2. Marc Würth

    Fixed typo

    ravage84 authored
  3. Marc Würth

    Added a note about plugin assets not working witout url rewrite

    ravage84 authored
    http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit
    
    --> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin."
    
    --> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience."
    
    see also:
    http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem
    
    http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8
  4. Marc Würth

    Added a note about plugin assets not working without url rewrite

    ravage84 authored
    http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit
    
    --> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin."
    
    --> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience."
    
    see also:
    http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem
    
    http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8
  5. Marc Würth

    Fixed introduced typo...

    ravage84 authored
  6. Marc Würth
  7. Marc Würth
Commits on Feb 3, 2013
  1. Marc Würth
  2. Marc Würth

    Added a note about plugin assets not working without url rewrite

    ravage84 authored
    http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit
    
    --> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin."
    
    --> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience."
    
    see also:
    http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem
    
    http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8
    
    Fixed typo
    
    Fixed typo
    
    Added a note about plugin assets not working witout url rewrite
    
    http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit
    
    --> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin."
    
    --> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience."
    
    see also:
    http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem
    
    http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8
    
    Fixed introduced typo...
    
    Addition to App.baseurl
    
    cakephp/cakephp#1113 (comment)
    
    Addition to App.baseurl
    
    cakephp/cakephp#1113 (comment)
    
    Fixed two newly introduced typos
  3. Marc Würth
This page is out of date. Refresh to see the latest.
12 app/Config/core.php
View
@@ -92,7 +92,15 @@
* /app/.htaccess
* /app/webroot/.htaccess
*
- * And uncomment the App.baseUrl below:
+ * And uncomment the App.baseUrl below. But keep in mind
+ * that plugin assets such as images, CSS and Javascript files
+ * will not work without url rewriting!
ADmad Collaborator
ADmad added a note

Should probably also add the solution. i.e. you should either copy or symlink the plugin assets into webroot

Marc Würth
ravage84 added a note

What do you think about this addition?

To work around this issue you should either symlink or copy the plugin assets into you app's webroot directory. This is recommended even when you are using mod_rewrite. Handling static assets through the Dispatcher is incredibly inefficient and included primarily as a development convenience - and thus not recommended for production applications.

ADmad Collaborator
ADmad added a note

:+1: Please squash your commits after making this change.

Marc Würth
ravage84 added a note

Should be squashed now. Fixed also my typos. Thanks

ADmad Collaborator
ADmad added a note

No the commits are not squashed. Your pull request now has 8 commits and expected is just 1 :smile:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ * To work around this issue you should either symlink or copy
+ * the plugin assets into you app's webroot directory. This is
+ * recommended even when you are using mod_rewrite. Handling static
+ * assets through the Dispatcher is incredibly inefficient and
+ * included primarily as a development convenience - and
+ * thus not recommended for production applications.
*/
//Configure::write('App.baseUrl', env('SCRIPT_NAME'));
@@ -246,7 +254,7 @@
*
* Note: 'default' and other application caches should be configured in app/Config/bootstrap.php.
* Please check the comments in boostrap.php for more info on the cache engines available
- * and their setttings.
+ * and their settings.
*/
$engine = 'File';
12 lib/Cake/Console/Templates/skel/Config/core.php
View
@@ -92,7 +92,15 @@
* /app/.htaccess
* /app/webroot/.htaccess
*
- * And uncomment the App.baseUrl below:
+ * And uncomment the App.baseUrl below. But keep in mind
+ * that plugin assets such as images, CSS and Javascript files
+ * will not work without url rewriting!
+ * To work around this issue you should either symlink or copy
+ * the plugin assets into you app's webroot directory. This is
+ * recommended even when you are using mod_rewrite. Handling static
+ * assets through the Dispatcher is incredibly inefficient and
+ * included primarily as a development convenience - and
+ * thus not recommended for production applications.
*/
//Configure::write('App.baseUrl', env('SCRIPT_NAME'));
@@ -307,7 +315,7 @@
*
* Note: 'default' and other application caches should be configured in app/Config/bootstrap.php.
* Please check the comments in boostrap.php for more info on the cache engines available
- * and their setttings.
+ * and their settings.
*/
$engine = 'File';
Something went wrong with that request. Please try again.