From 85ba689bea6491f06080680d1659f2a99b94cefd Mon Sep 17 00:00:00 2001 From: ravage84 Date: Sat, 2 Feb 2013 19:53:18 +0100 Subject: [PATCH 1/9] Fixed typo --- lib/Cake/Console/Templates/skel/Config/core.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Cake/Console/Templates/skel/Config/core.php b/lib/Cake/Console/Templates/skel/Config/core.php index d7fbe3a098e..24233c932f6 100644 --- a/lib/Cake/Console/Templates/skel/Config/core.php +++ b/lib/Cake/Console/Templates/skel/Config/core.php @@ -307,7 +307,7 @@ * * Note: 'default' and other application caches should be configured in app/Config/bootstrap.php. * Please check the comments in boostrap.php for more info on the cache engines available - * and their setttings. + * and their settings. */ $engine = 'File'; From f5038de75733fb33b7fef33146cc2f9e39a80937 Mon Sep 17 00:00:00 2001 From: ravage84 Date: Sat, 2 Feb 2013 20:08:55 +0100 Subject: [PATCH 2/9] Fixed typo --- app/Config/core.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Config/core.php b/app/Config/core.php index 60e31654b3e..f5320eabde5 100644 --- a/app/Config/core.php +++ b/app/Config/core.php @@ -246,7 +246,7 @@ * * Note: 'default' and other application caches should be configured in app/Config/bootstrap.php. * Please check the comments in boostrap.php for more info on the cache engines available - * and their setttings. + * and their settings. */ $engine = 'File'; From bf91266f21ef51362e6d33f5acc2c4adb9d0d056 Mon Sep 17 00:00:00 2001 From: ravage84 Date: Sat, 2 Feb 2013 20:17:10 +0100 Subject: [PATCH 3/9] Added a note about plugin assets not working witout url rewrite http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit --> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin." --> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience." see also: http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8 --- app/Config/core.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/Config/core.php b/app/Config/core.php index f5320eabde5..b3cc8167d01 100644 --- a/app/Config/core.php +++ b/app/Config/core.php @@ -92,7 +92,9 @@ * /app/.htaccess * /app/webroot/.htaccess * - * And uncomment the App.baseUrl below: + * And uncomment the App.baseUrl below. But keep in mind + * that plugin assets such as images, CSS and Javascript files + * will not without url rewriting! */ //Configure::write('App.baseUrl', env('SCRIPT_NAME')); From d049a3f6c79487f005d5fb0a2401e981f1fb2e40 Mon Sep 17 00:00:00 2001 From: ravage84 Date: Sat, 2 Feb 2013 20:19:40 +0100 Subject: [PATCH 4/9] Added a note about plugin assets not working without url rewrite http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit --> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin." --> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience." see also: http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8 --- lib/Cake/Console/Templates/skel/Config/core.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/Cake/Console/Templates/skel/Config/core.php b/lib/Cake/Console/Templates/skel/Config/core.php index 24233c932f6..df86d12cc25 100644 --- a/lib/Cake/Console/Templates/skel/Config/core.php +++ b/lib/Cake/Console/Templates/skel/Config/core.php @@ -92,7 +92,9 @@ * /app/.htaccess * /app/webroot/.htaccess * - * And uncomment the App.baseUrl below: + * And uncomment the App.baseUrl below. But keep in mind + * that plugin assets such as images, CSS and Javascript files + * will not work without url rewriting! */ //Configure::write('App.baseUrl', env('SCRIPT_NAME')); From 3c10322a860622efa71e725afe79efd887c34d7e Mon Sep 17 00:00:00 2001 From: ravage84 Date: Sat, 2 Feb 2013 20:20:41 +0100 Subject: [PATCH 5/9] Fixed introduced typo... --- app/Config/core.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Config/core.php b/app/Config/core.php index b3cc8167d01..df8f336840a 100644 --- a/app/Config/core.php +++ b/app/Config/core.php @@ -94,7 +94,7 @@ * * And uncomment the App.baseUrl below. But keep in mind * that plugin assets such as images, CSS and Javascript files - * will not without url rewriting! + * will not work without url rewriting! */ //Configure::write('App.baseUrl', env('SCRIPT_NAME')); From c33cdcc45f019ae9bb543d772e239a9aef3b7857 Mon Sep 17 00:00:00 2001 From: ravage84 Date: Sat, 2 Feb 2013 21:16:14 +0100 Subject: [PATCH 6/9] Addition to App.baseurl https://github.com/cakephp/cakephp/pull/1113#discussion_r2869545 --- app/Config/core.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/Config/core.php b/app/Config/core.php index df8f336840a..d47c374bcc2 100644 --- a/app/Config/core.php +++ b/app/Config/core.php @@ -95,6 +95,12 @@ * And uncomment the App.baseUrl below. But keep in mind * that plugin assets such as images, CSS and Javascript files * will not work without url rewriting! + * To work around this issue you should either symlink or copy + * the plugin assets into you app's webroot directory. This is + * ecommended even when you are using mod_rewrite. Handling static + * assets through the Dispatcher is incredibly inefficient and + * included primarily as a development convenience - and + * thus not recommended for production applications. */ //Configure::write('App.baseUrl', env('SCRIPT_NAME')); From ad953c3360e814252359611441b22b0be4d6a3c8 Mon Sep 17 00:00:00 2001 From: ravage84 Date: Sat, 2 Feb 2013 21:18:44 +0100 Subject: [PATCH 7/9] Addition to App.baseurl https://github.com/cakephp/cakephp/pull/1113#discussion_r2869545 --- lib/Cake/Console/Templates/skel/Config/core.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/Cake/Console/Templates/skel/Config/core.php b/lib/Cake/Console/Templates/skel/Config/core.php index df86d12cc25..7a769f40da3 100644 --- a/lib/Cake/Console/Templates/skel/Config/core.php +++ b/lib/Cake/Console/Templates/skel/Config/core.php @@ -95,6 +95,12 @@ * And uncomment the App.baseUrl below. But keep in mind * that plugin assets such as images, CSS and Javascript files * will not work without url rewriting! + * To work around this issue you should either symlink or copy + * the plugin assets into you app's webroot directory. This is + * ecommended even when you are using mod_rewrite. Handling static + * assets through the Dispatcher is incredibly inefficient and + * included primarily as a development convenience - and + * thus not recommended for production applications. */ //Configure::write('App.baseUrl', env('SCRIPT_NAME')); From 1d54622335965d9d9ec681446e0532fb16360638 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc=20W=C3=BCrth?= Date: Sun, 3 Feb 2013 16:16:03 +0100 Subject: [PATCH 8/9] Fixed two newly introduced typos --- app/Config/core.php | 2 +- lib/Cake/Console/Templates/skel/Config/core.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/Config/core.php b/app/Config/core.php index d47c374bcc2..31de11b53b7 100644 --- a/app/Config/core.php +++ b/app/Config/core.php @@ -97,7 +97,7 @@ * will not work without url rewriting! * To work around this issue you should either symlink or copy * the plugin assets into you app's webroot directory. This is - * ecommended even when you are using mod_rewrite. Handling static + * recommended even when you are using mod_rewrite. Handling static * assets through the Dispatcher is incredibly inefficient and * included primarily as a development convenience - and * thus not recommended for production applications. diff --git a/lib/Cake/Console/Templates/skel/Config/core.php b/lib/Cake/Console/Templates/skel/Config/core.php index 7a769f40da3..cc14a58770c 100644 --- a/lib/Cake/Console/Templates/skel/Config/core.php +++ b/lib/Cake/Console/Templates/skel/Config/core.php @@ -92,12 +92,12 @@ * /app/.htaccess * /app/webroot/.htaccess * - * And uncomment the App.baseUrl below. But keep in mind + * And uncomment the App.baseUrl below. But keep in mind * that plugin assets such as images, CSS and Javascript files * will not work without url rewriting! * To work around this issue you should either symlink or copy * the plugin assets into you app's webroot directory. This is - * ecommended even when you are using mod_rewrite. Handling static + * recommended even when you are using mod_rewrite. Handling static * assets through the Dispatcher is incredibly inefficient and * included primarily as a development convenience - and * thus not recommended for production applications. From a5813eda499d395bae0ff114d7893771d8d9c3a3 Mon Sep 17 00:00:00 2001 From: ravage84 Date: Sat, 2 Feb 2013 20:19:40 +0100 Subject: [PATCH 9/9] Added a note about plugin assets not working without url rewrite http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit --> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin." --> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience." see also: http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8 Fixed typo Fixed typo Added a note about plugin assets not working witout url rewrite http://cakephp.lighthouseapp.com/projects/42880/tickets/25-i-installed-but-dont-see-the-images-and-css-of-debugkit --> "Plugin assets do not work without url rewriting, this is in the documentation for CakePHP itself. I guess it could be repeated for this and every other plugin." --> "I could have sworn it was with the Plugin Assets section, but apparently its not there. Perhaps its just something I know from experience." see also: http://cakephp.lighthouseapp.com/projects/42648/tickets/1755-plugin-webroot-without-mod_rewrite-problem http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/500-plugin-css-directories-bug#ticket-500-8 Fixed introduced typo... Addition to App.baseurl https://github.com/cakephp/cakephp/pull/1113#discussion_r2869545 Addition to App.baseurl https://github.com/cakephp/cakephp/pull/1113#discussion_r2869545 Fixed two newly introduced typos --- app/Config/core.php | 12 ++++++++++-- lib/Cake/Console/Templates/skel/Config/core.php | 12 ++++++++++-- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/app/Config/core.php b/app/Config/core.php index 60e31654b3e..31de11b53b7 100644 --- a/app/Config/core.php +++ b/app/Config/core.php @@ -92,7 +92,15 @@ * /app/.htaccess * /app/webroot/.htaccess * - * And uncomment the App.baseUrl below: + * And uncomment the App.baseUrl below. But keep in mind + * that plugin assets such as images, CSS and Javascript files + * will not work without url rewriting! + * To work around this issue you should either symlink or copy + * the plugin assets into you app's webroot directory. This is + * recommended even when you are using mod_rewrite. Handling static + * assets through the Dispatcher is incredibly inefficient and + * included primarily as a development convenience - and + * thus not recommended for production applications. */ //Configure::write('App.baseUrl', env('SCRIPT_NAME')); @@ -246,7 +254,7 @@ * * Note: 'default' and other application caches should be configured in app/Config/bootstrap.php. * Please check the comments in boostrap.php for more info on the cache engines available - * and their setttings. + * and their settings. */ $engine = 'File'; diff --git a/lib/Cake/Console/Templates/skel/Config/core.php b/lib/Cake/Console/Templates/skel/Config/core.php index d7fbe3a098e..cc14a58770c 100644 --- a/lib/Cake/Console/Templates/skel/Config/core.php +++ b/lib/Cake/Console/Templates/skel/Config/core.php @@ -92,7 +92,15 @@ * /app/.htaccess * /app/webroot/.htaccess * - * And uncomment the App.baseUrl below: + * And uncomment the App.baseUrl below. But keep in mind + * that plugin assets such as images, CSS and Javascript files + * will not work without url rewriting! + * To work around this issue you should either symlink or copy + * the plugin assets into you app's webroot directory. This is + * recommended even when you are using mod_rewrite. Handling static + * assets through the Dispatcher is incredibly inefficient and + * included primarily as a development convenience - and + * thus not recommended for production applications. */ //Configure::write('App.baseUrl', env('SCRIPT_NAME')); @@ -307,7 +315,7 @@ * * Note: 'default' and other application caches should be configured in app/Config/bootstrap.php. * Please check the comments in boostrap.php for more info on the cache engines available - * and their setttings. + * and their settings. */ $engine = 'File';