New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias fields when finding dependent records to delete. #11181

Merged
merged 1 commit into from Sep 18, 2017

Conversation

Projects
None yet
2 participants
@markstory
Member

markstory commented Sep 14, 2017

Prevent ambiguous column issues by aliasing fields used in conditions.

Refs #11170

Alias fields when finding dependent records to delete.
Prevent ambiguous column issues by aliasing fields used in conditions.

Refs #11170

@markstory markstory added the ORM label Sep 14, 2017

@markstory markstory added this to the 3.5.3 milestone Sep 14, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 14, 2017

Codecov Report

Merging #11181 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11181      +/-   ##
============================================
- Coverage     93.15%   93.14%   -0.01%     
  Complexity    12981    12981              
============================================
  Files           437      437              
  Lines         33624    33624              
============================================
- Hits          31322    31319       -3     
- Misses         2302     2305       +3
Impacted Files Coverage Δ Complexity Δ
src/ORM/Association/DependentDeleteHelper.php 100% <100%> (ø) 4 <0> (ø) ⬇️
src/Cache/CacheEngine.php 89.36% <0%> (-4.26%) 19% <0%> (ø)
src/Cache/CacheRegistry.php 96% <0%> (-4%) 11% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8262b4d...0c7856b. Read the comment docs.

codecov-io commented Sep 14, 2017

Codecov Report

Merging #11181 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11181      +/-   ##
============================================
- Coverage     93.15%   93.14%   -0.01%     
  Complexity    12981    12981              
============================================
  Files           437      437              
  Lines         33624    33624              
============================================
- Hits          31322    31319       -3     
- Misses         2302     2305       +3
Impacted Files Coverage Δ Complexity Δ
src/ORM/Association/DependentDeleteHelper.php 100% <100%> (ø) 4 <0> (ø) ⬇️
src/Cache/CacheEngine.php 89.36% <0%> (-4.26%) 19% <0%> (ø)
src/Cache/CacheRegistry.php 96% <0%> (-4%) 11% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8262b4d...0c7856b. Read the comment docs.

@markstory markstory merged commit 173293f into master Sep 18, 2017

6 checks passed

codecov/patch 100% of diff hit (target 93.15%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +6.84% compared to 8262b4d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
stickler-ci No lint errors found.

@markstory markstory deleted the issue-11170 branch Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment