Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
False positive URL validation (Test case only) #11211
with Kibana urls for instance
Kibana urls such as this one are not valid whereas they seem to be valid regarding the specs (valid in an
The sample url in this failing test can be found from the "Share" tab of a dashboard in the latest Kibana version.
The PR only contains the failing test case for now, I will try to look at the regex and update the PR if nobody beats me to it!
@@ Coverage Diff @@ ## master #11211 +/- ## ============================================ - Coverage 93.14% 93.13% -0.02% - Complexity 12981 12984 +3 ============================================ Files 437 437 Lines 33626 33641 +15 ============================================ + Hits 31321 31331 +10 - Misses 2305 2310 +5