New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive URL validation (Test case only) #11211

Merged
merged 2 commits into from Sep 26, 2017

Conversation

Projects
None yet
4 participants
@real34
Member

real34 commented Sep 19, 2017

with Kibana urls for instance

Kibana urls such as this one are not valid whereas they seem to be valid regarding the specs (valid in an input type=url for instance). The failure seems to be related to the presence of the trailing ?_g=() part.

The sample url in this failing test can be found from the "Share" tab of a dashboard in the latest Kibana version.

kibana-report-template-dashboard-link

The PR only contains the failing test case for now, I will try to look at the regex and update the PR if nobody beats me to it!

@dereuromark dereuromark added this to the 3.5.3 milestone Sep 19, 2017

@dereuromark dereuromark added the Defect label Sep 19, 2017

@markstory markstory self-assigned this Sep 19, 2017

Allow / and ? in fragments.
This matches the rules defined in RFC 3986 Section 3.5
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 26, 2017

Codecov Report

Merging #11211 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11211      +/-   ##
============================================
- Coverage     93.14%   93.13%   -0.02%     
- Complexity    12981    12984       +3     
============================================
  Files           437      437              
  Lines         33626    33641      +15     
============================================
+ Hits          31321    31331      +10     
- Misses         2305     2310       +5
Impacted Files Coverage Δ Complexity Δ
src/Validation/Validation.php 94.57% <100%> (+0.04%) 239 <0> (ø) ⬇️
src/ORM/Behavior/CounterCacheBehavior.php 97.18% <0%> (-2.82%) 32% <0%> (ø)
src/ORM/AssociationCollection.php 97.67% <0%> (-2.33%) 36% <0%> (+1%)
src/I18n/RelativeTimeFormatter.php 95.02% <0%> (-0.5%) 74% <0%> (ø)
src/Controller/Controller.php 95.28% <0%> (-0.03%) 77% <0%> (ø)
src/Network/Socket.php 70.5% <0%> (ø) 55% <0%> (ø) ⬇️
src/Mailer/AbstractTransport.php 100% <0%> (ø) 7% <0%> (ø) ⬇️
src/ORM/Query.php 97.45% <0%> (ø) 96% <0%> (ø) ⬇️
src/Log/Engine/BaseLog.php 100% <0%> (ø) 16% <0%> (ø) ⬇️
src/Auth/BaseAuthenticate.php 96.15% <0%> (ø) 18% <0%> (ø) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173293f...b6f439f. Read the comment docs.

codecov-io commented Sep 26, 2017

Codecov Report

Merging #11211 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11211      +/-   ##
============================================
- Coverage     93.14%   93.13%   -0.02%     
- Complexity    12981    12984       +3     
============================================
  Files           437      437              
  Lines         33626    33641      +15     
============================================
+ Hits          31321    31331      +10     
- Misses         2305     2310       +5
Impacted Files Coverage Δ Complexity Δ
src/Validation/Validation.php 94.57% <100%> (+0.04%) 239 <0> (ø) ⬇️
src/ORM/Behavior/CounterCacheBehavior.php 97.18% <0%> (-2.82%) 32% <0%> (ø)
src/ORM/AssociationCollection.php 97.67% <0%> (-2.33%) 36% <0%> (+1%)
src/I18n/RelativeTimeFormatter.php 95.02% <0%> (-0.5%) 74% <0%> (ø)
src/Controller/Controller.php 95.28% <0%> (-0.03%) 77% <0%> (ø)
src/Network/Socket.php 70.5% <0%> (ø) 55% <0%> (ø) ⬇️
src/Mailer/AbstractTransport.php 100% <0%> (ø) 7% <0%> (ø) ⬇️
src/ORM/Query.php 97.45% <0%> (ø) 96% <0%> (ø) ⬇️
src/Log/Engine/BaseLog.php 100% <0%> (ø) 16% <0%> (ø) ⬇️
src/Auth/BaseAuthenticate.php 96.15% <0%> (ø) 18% <0%> (ø) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173293f...b6f439f. Read the comment docs.

@markstory markstory merged commit aeff92a into cakephp:master Sep 26, 2017

5 of 6 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
codecov/patch 100% of diff hit (target 93.14%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +6.85% compared to 173293f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.

@real34 real34 deleted the occitech:fix/support-kibana-urls branch Sep 26, 2017

@real34

This comment has been minimized.

Show comment
Hide comment
@real34

real34 Sep 26, 2017

Member

Thank you for your work on this!

Member

real34 commented Sep 26, 2017

Thank you for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment