New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in CakeEmail matching pattern #11222

Merged
merged 5 commits into from Sep 23, 2017

Conversation

Projects
None yet
5 participants
@IonutBurlacu

IonutBurlacu commented Sep 21, 2017

No description provided.

IonutBurlacu added some commits Sep 21, 2017

@dereuromark

This comment has been minimized.

Show comment
Hide comment
@dereuromark

dereuromark Sep 21, 2017

Member

We should have a test case with such an example domain to prevent regressions.

We probably also need to port this to 3.x then.

Member

dereuromark commented Sep 21, 2017

We should have a test case with such an example domain to prevent regressions.

We probably also need to port this to 3.x then.

@dereuromark dereuromark added the Defect label Sep 21, 2017

@dereuromark dereuromark added this to the 2.10.4 milestone Sep 21, 2017

@dereuromark dereuromark referenced this pull request Sep 21, 2017

Closed

Bug in CakeEmail matching pattern #11221

1 of 3 tasks complete

@markstory markstory self-assigned this Sep 21, 2017

@gemal

This comment has been minimized.

Show comment
Hide comment
@gemal

gemal Sep 22, 2017

Contributor

can this be merged?

Contributor

gemal commented Sep 22, 2017

can this be merged?

@dereuromark

This comment has been minimized.

Show comment
Hide comment
@dereuromark

dereuromark Sep 22, 2017

Member

I mentioned above that a test case is critical for this to be mergable.

Member

dereuromark commented Sep 22, 2017

I mentioned above that a test case is critical for this to be mergable.

@gemal

This comment has been minimized.

Show comment
Hide comment
@gemal

gemal Sep 22, 2017

Contributor

ok. sorry. we are doing the test case now

Contributor

gemal commented Sep 22, 2017

ok. sorry. we are doing the test case now

IonutBurlacu added some commits Sep 22, 2017

@IonutBurlacu

This comment has been minimized.

Show comment
Hide comment
@IonutBurlacu

IonutBurlacu Sep 22, 2017

Not sure why the tests failed but it seems that it's not caused by my changes.

IonutBurlacu commented Sep 22, 2017

Not sure why the tests failed but it seems that it's not caused by my changes.

@dereuromark

This comment has been minimized.

Show comment
Hide comment
@dereuromark

dereuromark Sep 22, 2017

Member

Yes, unrelated. I re-triggered it.

Member

dereuromark commented Sep 22, 2017

Yes, unrelated. I re-triggered it.

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Sep 22, 2017

Are underscores actually allowed in domain names?

thaJeztah commented Sep 22, 2017

Are underscores actually allowed in domain names?

@dereuromark

This comment has been minimized.

Show comment
Hide comment
@markstory

This comment has been minimized.

Show comment
Hide comment
@markstory

markstory Sep 22, 2017

Member

I'll get this merged and ported to 3.x

Member

markstory commented Sep 22, 2017

I'll get this merged and ported to 3.x

@markstory markstory merged commit 8d0590c into cakephp:2.x Sep 23, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci Pull request targets an ignored branch

markstory added a commit that referenced this pull request Sep 23, 2017

Allow _ in domain names that email can be sent to.
Port changes from #11222 to 3.x. Subdomains and internal DNS allow _ to
be used.

o0h added a commit to o0h/cakephp that referenced this pull request Nov 16, 2017

Allow _ in domain names that email can be sent to.
Port changes from cakephp#11222 to 3.x. Subdomains and internal DNS allow _ to
be used.

o0h added a commit to o0h/cakephp that referenced this pull request Dec 30, 2017

Allow _ in domain names that email can be sent to.
Port changes from cakephp#11222 to 3.x. Subdomains and internal DNS allow _ to
be used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment