New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use interface const instead of magic strings for LEFT/RIGHT/INNER joi… #11237

Merged
merged 1 commit into from Sep 25, 2017

Conversation

Projects
None yet
2 participants
@dereuromark
Member

dereuromark commented Sep 25, 2017

…n types.

Less typos this way. Also less typing as the IDE auto-completes when adding via const.
And you can use the IDE for getting usage across project/code if needed.

@dereuromark dereuromark added this to the 3.5.3 milestone Sep 25, 2017

@markstory markstory merged commit 59420ac into master Sep 25, 2017

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
stickler-ci No lint errors found.

@markstory markstory deleted the master-less-magic-strings branch Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment